[PATCH] isofs: remove unused functions

[PATCH] isofs: remove unused functions

[Sudip Mukherjee]

commit "5b71ecfa78271d5c576f17156ed8a53981c1ecbb" removed the use
two functions isofs_hash() and isofs_dentry_cmp() , but their
definition was not removed.
So, as these functions are not used anywhere so it is safe to
remove them. It has been build tested after removing.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 fs/isofs/inode.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
index 859a309..fe839b9 100644
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -29,13 +29,9 @@
 #define BEQUIET
 
 static int isofs_hashi(const struct dentry *parent, struct qstr *qstr);
-static int isofs_hash(const struct dentry *parent, struct qstr *qstr);
 static int isofs_dentry_cmpi(const struct dentry *parent,
 		const struct dentry *dentry,
 		unsigned int len, const char *str, const struct qstr *name);
-static int isofs_dentry_cmp(const struct dentry *parent,
-		const struct dentry *dentry,
-		unsigned int len, const char *str, const struct qstr *name);
 
 #ifdef CONFIG_JOLIET
 static int isofs_hashi_ms(const struct dentry *parent, struct qstr *qstr);
@@ -254,25 +250,12 @@ static int isofs_dentry_cmp_common(
 }
 
 static int
-isofs_hash(const struct dentry *dentry, struct qstr *qstr)
-{
-	return isofs_hash_common(qstr, 0);
-}
-
-static int
 isofs_hashi(const struct dentry *dentry, struct qstr *qstr)
 {
 	return isofs_hashi_common(qstr, 0);
 }
 
 static int
-isofs_dentry_cmp(const struct dentry *parent, const struct dentry *dentry,
-		unsigned int len, const char *str, const struct qstr *name)
-{
-	return isofs_dentry_cmp_common(len, str, name, 0, 0);
-}
-
-static int
 isofs_dentry_cmpi(const struct dentry *parent, const struct dentry *dentry,
 		unsigned int len, const char *str, const struct qstr *name)
 {
-- 
1.8.1.2

Re: [PATCH] isofs: remove unused functions

[Jan Kara]

On Fri 31-10-14 17:43:48, Sudip Mukherjee wrote:
> commit "5b71ecfa78271d5c576f17156ed8a53981c1ecbb" removed the use
> two functions isofs_hash() and isofs_dentry_cmp() , but their
> definition was not removed.
> So, as these functions are not used anywhere so it is safe to
> remove them. It has been build tested after removing.
  Thanks for the patch. One note though - after your patch
isofs_hash_common() is called from a single place so there's no point to
have that function. You can just inline it in isofs_hash_ms(). Please do
that when we are messing with the code.

								Honza
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  fs/isofs/inode.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index 859a309..fe839b9 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -29,13 +29,9 @@
>  #define BEQUIET
>  
>  static int isofs_hashi(const struct dentry *parent, struct qstr *qstr);
> -static int isofs_hash(const struct dentry *parent, struct qstr *qstr);
>  static int isofs_dentry_cmpi(const struct dentry *parent,
>  		const struct dentry *dentry,
>  		unsigned int len, const char *str, const struct qstr *name);
> -static int isofs_dentry_cmp(const struct dentry *parent,
> -		const struct dentry *dentry,
> -		unsigned int len, const char *str, const struct qstr *name);
>  
>  #ifdef CONFIG_JOLIET
>  static int isofs_hashi_ms(const struct dentry *parent, struct qstr *qstr);
> @@ -254,25 +250,12 @@ static int isofs_dentry_cmp_common(
>  }
>  
>  static int
> -isofs_hash(const struct dentry *dentry, struct qstr *qstr)
> -{
> -	return isofs_hash_common(qstr, 0);
> -}
> -
> -static int
>  isofs_hashi(const struct dentry *dentry, struct qstr *qstr)
>  {
>  	return isofs_hashi_common(qstr, 0);
>  }
>  
>  static int
> -isofs_dentry_cmp(const struct dentry *parent, const struct dentry *dentry,
> -		unsigned int len, const char *str, const struct qstr *name)
> -{
> -	return isofs_dentry_cmp_common(len, str, name, 0, 0);
> -}
> -
> -static int
>  isofs_dentry_cmpi(const struct dentry *parent, const struct dentry *dentry,
>  		unsigned int len, const char *str, const struct qstr *name)
>  {
> -- 
> 1.8.1.2
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: [PATCH] isofs: remove unused functions

[Al Viro]

On Fri, Oct 31, 2014 at 05:43:48PM +0530, Sudip Mukherjee wrote:
> commit "5b71ecfa78271d5c576f17156ed8a53981c1ecbb" removed the use
> two functions isofs_hash() and isofs_dentry_cmp() , but their
> definition was not removed.
> So, as these functions are not used anywhere so it is safe to
> remove them. It has been build tested after removing.

Umm...  Already in b0afd8e5db7b11aa9078e82e7f9abc30dc35a3c1 (and AFAICS
the incremental is the same as yours).

Re: [PATCH] isofs: remove unused functions

[Sudip Mukherjee]

On Fri, Oct 31, 2014 at 05:01:56PM +0000, Al Viro wrote:
> On Fri, Oct 31, 2014 at 05:43:48PM +0530, Sudip Mukherjee wrote:
> > commit "5b71ecfa78271d5c576f17156ed8a53981c1ecbb" removed the use
> > two functions isofs_hash() and isofs_dentry_cmp() , but their
> > definition was not removed.
> > So, as these functions are not used anywhere so it is safe to
> > remove them. It has been build tested after removing.
> 
> Umm...  Already in b0afd8e5db7b11aa9078e82e7f9abc30dc35a3c1 (and AFAICS
> the incremental is the same as yours).
so , since it is alredy commited then i am not sending the modified patch.

thanks
sudip