public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: josh@joshtriplett.org
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, Matt Fleming <matt.fleming@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Junjie Mao <eternal.n08@gmail.com>
Subject: Re: [PATCH] x86, boot: document intermediates more clearly
Date: Fri, 31 Oct 2014 13:16:34 -0700	[thread overview]
Message-ID: <20141031201634.GA32605@cloud> (raw)
In-Reply-To: <20141031162204.GA26268@www.outflux.net>

On Fri, Oct 31, 2014 at 09:22:04AM -0700, Kees Cook wrote:
> This adds a comment detailing the various intermediate files used to build
> the bootable decompression image for the x86 kernel.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Definitely the documentation I wish I had long ago when trying to figure
out the twisty maze of binaries.

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  arch/x86/boot/compressed/Makefile | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index be1e07d4b596..44a866b85c6f 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -3,6 +3,18 @@
>  #
>  # create a compressed vmlinux image from the original vmlinux
>  #
> +# vmlinuz is:
> +#	decompression code (*.o)
> +#	asm globals (piggy.S), including:
> +#		vmlinux.bin.(gz|bz2|lzma|...)
> +#
> +# vmlinux.bin is:
> +#	vmlinux stripped of debugging and comments
> +# vmlinux.bin.all is:
> +#	vmlinux.bin + vmlinux.relocs
> +# vmlinux.bin.(gz|bz2|lzma|...) is:
> +#	(see scripts/Makefile.lib size_append)
> +#	compressed vmlinux.bin.all + u32 size of vmlinux.bin.all
>  
>  targets := vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma \
>  	vmlinux.bin.xz vmlinux.bin.lzo vmlinux.bin.lz4
> -- 
> 1.9.1
> 
> 
> -- 
> Kees Cook
> Chrome OS Security

  reply	other threads:[~2014-10-31 20:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31 16:22 [PATCH] x86, boot: document intermediates more clearly Kees Cook
2014-10-31 20:16 ` josh [this message]
2014-11-01 21:48 ` [tip:x86/boot] x86, boot: Document " tip-bot for Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141031201634.GA32605@cloud \
    --to=josh@joshtriplett.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=eternal.n08@gmail.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox