public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] staging: panel: Remove outdated TODO tasks
@ 2014-10-31 22:01 Mariusz Gorski
  2014-10-31 22:08 ` Konrad Zapalowicz
  0 siblings, 1 reply; 4+ messages in thread
From: Mariusz Gorski @ 2014-10-31 22:01 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Willy Tarreau; +Cc: devel, linux-kernel

Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.

Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
---
v3: Fixed commit summary

 drivers/staging/panel/TODO | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
index a4be749..c8040c1 100644
--- a/drivers/staging/panel/TODO
+++ b/drivers/staging/panel/TODO
@@ -1,6 +1,4 @@
 TODO:
-	- checkpatch.pl cleanups
-	- Lindent
 	- review major/minor usages
 	- review userspace api
 	- see if all of this could be easier done in userspace instead.
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] staging: panel: Remove outdated TODO tasks
  2014-10-31 22:01 [PATCH v3] staging: panel: Remove outdated TODO tasks Mariusz Gorski
@ 2014-10-31 22:08 ` Konrad Zapalowicz
  2014-11-01  4:59   ` Sudip Mukherjee
  0 siblings, 1 reply; 4+ messages in thread
From: Konrad Zapalowicz @ 2014-10-31 22:08 UTC (permalink / raw)
  To: Mariusz Gorski; +Cc: Greg Kroah-Hartman, Willy Tarreau, devel, linux-kernel

On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
> 
> Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
> ---
> v3: Fixed commit summary

Great. Thanks.

regards,
konrad
 
>  drivers/staging/panel/TODO | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
> index a4be749..c8040c1 100644
> --- a/drivers/staging/panel/TODO
> +++ b/drivers/staging/panel/TODO
> @@ -1,6 +1,4 @@
>  TODO:
> -	- checkpatch.pl cleanups
> -	- Lindent
>  	- review major/minor usages
>  	- review userspace api
>  	- see if all of this could be easier done in userspace instead.
> -- 
> 2.1.3
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] staging: panel: Remove outdated TODO tasks
  2014-10-31 22:08 ` Konrad Zapalowicz
@ 2014-11-01  4:59   ` Sudip Mukherjee
  2014-11-01 10:50     ` Mariusz Gorski
  0 siblings, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2014-11-01  4:59 UTC (permalink / raw)
  To: Konrad Zapalowicz
  Cc: Mariusz Gorski, Greg Kroah-Hartman, Willy Tarreau, devel,
	linux-kernel

On Fri, Oct 31, 2014 at 11:08:34PM +0100, Konrad Zapalowicz wrote:
> On 10/31, Mariusz Gorski wrote:
> > Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> > is obsolete and the other one is already done.
> > 

when i checked panel.c with checkpatch and with --strict option, i got 20 checks.
(sent the same reply to v1 patch also).

thanks
sudip

> > Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
> > ---
> > v3: Fixed commit summary
> 
> Great. Thanks.
> 
> regards,
> konrad
>  
> >  drivers/staging/panel/TODO | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
> > index a4be749..c8040c1 100644
> > --- a/drivers/staging/panel/TODO
> > +++ b/drivers/staging/panel/TODO
> > @@ -1,6 +1,4 @@
> >  TODO:
> > -	- checkpatch.pl cleanups
> > -	- Lindent
> >  	- review major/minor usages
> >  	- review userspace api
> >  	- see if all of this could be easier done in userspace instead.
> > -- 
> > 2.1.3
> > 
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] staging: panel: Remove outdated TODO tasks
  2014-11-01  4:59   ` Sudip Mukherjee
@ 2014-11-01 10:50     ` Mariusz Gorski
  0 siblings, 0 replies; 4+ messages in thread
From: Mariusz Gorski @ 2014-11-01 10:50 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: Konrad Zapalowicz, Greg Kroah-Hartman, Willy Tarreau, devel,
	linux-kernel

On Sat, Nov 01, 2014 at 10:29:16AM +0530, Sudip Mukherjee wrote:
> On Fri, Oct 31, 2014 at 11:08:34PM +0100, Konrad Zapalowicz wrote:
> > On 10/31, Mariusz Gorski wrote:
> > > Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> > > is obsolete and the other one is already done.
> > > 
> 
> when i checked panel.c with checkpatch and with --strict option, i got 20 checks.
> (sent the same reply to v1 patch also).

Good point, supid. Thanks! I guess the checkpatch.pl issues deserve a
separate patch, so I'll just reduce the scope of this one.

Cheers,
Mariusz

> thanks
> sudip
> 
> > > Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
> > > ---
> > > v3: Fixed commit summary
> > 
> > Great. Thanks.
> > 
> > regards,
> > konrad
> >  
> > >  drivers/staging/panel/TODO | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
> > > index a4be749..c8040c1 100644
> > > --- a/drivers/staging/panel/TODO
> > > +++ b/drivers/staging/panel/TODO
> > > @@ -1,6 +1,4 @@
> > >  TODO:
> > > -	- checkpatch.pl cleanups
> > > -	- Lindent
> > >  	- review major/minor usages
> > >  	- review userspace api
> > >  	- see if all of this could be easier done in userspace instead.
> > > -- 
> > > 2.1.3
> > > 
> > > _______________________________________________
> > > devel mailing list
> > > devel@linuxdriverproject.org
> > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-11-01 10:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 22:01 [PATCH v3] staging: panel: Remove outdated TODO tasks Mariusz Gorski
2014-10-31 22:08 ` Konrad Zapalowicz
2014-11-01  4:59   ` Sudip Mukherjee
2014-11-01 10:50     ` Mariusz Gorski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox