From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Chen Weixiang <weixiangchen@gmail.com>
Cc: Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chen Weixiang <weixiang.chen@gmail.com>,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Felipe Balbi <balbi@ti.com>, Nicolas Thery <nthery@gmail.com>,
Greg Donald <gdonald@gmail.com>,
Daniel Dodge <danieldodgese@gmail.com>,
Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] staging: ft1000: "(foo*)" should be "(foo *)"
Date: Sat, 1 Nov 2014 10:40:31 +0530 [thread overview]
Message-ID: <20141101051031.GE3642@sudip-PC> (raw)
In-Reply-To: <1414810047-6975-4-git-send-email-weixiang.chen@gmail.com>
On Sat, Nov 01, 2014 at 10:47:24AM +0800, Chen Weixiang wrote:
> Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
> ERROR: "(foo*)" should be "(foo *)"
>
again checkpatch gives total: 4 errors, 3 warnings, 16 lines checked.
this includes whitespace errors.
thanks
sudip
> Signed-off-by: Chen Weixiang <weixiang.chen@gmail.com>
> ---
> drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> index 02bfb3e..7bc05fe 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> @@ -447,7 +447,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
> switch (cmd) {
> case IOCTL_REGISTER_CMD:
> DEBUG("FT1000:ft1000_ioctl: IOCTL_FT1000_REGISTER called\n");
> - result = get_user(tempword, (__u16 __user*)argp);
> + result = get_user(tempword, (__u16 __user *)argp);
> if (result) {
> DEBUG("result = %d failed to get_user\n", result);
> break;
> @@ -652,7 +652,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
> }
> pmsg++;
> ppseudo_hdr = (struct pseudo_hdr *)pmsg;
> - result = card_send_command(ft1000dev,(unsigned short*)dpram_data,total_len+2);
> + result = card_send_command(ft1000dev,(unsigned short *)dpram_data,total_len+2);
>
>
> ft1000dev->app_info[app_index].nTxMsg++;
> --
> 2.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-11-01 5:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 2:47 [PATCH v2 0/6] Remove checkpatch.pl errors from drivers/staging/ft1000 Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '==' Chen Weixiang
2014-11-01 5:05 ` Sudip Mukherjee
2014-11-01 5:14 ` Joe Perches
2014-11-01 5:25 ` Sudip Mukherjee
2014-11-01 5:30 ` Sudip Mukherjee
2014-11-01 5:47 ` Sudip Mukherjee
2014-11-01 14:51 ` Chen Weixiang
2014-11-01 14:09 ` Chen Weixiang
2014-11-01 16:29 ` Sudip Mukherjee
2014-11-04 0:05 ` Greg Kroah-Hartman
2014-11-10 0:16 ` Chen Weixiang
2014-11-10 1:00 ` Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 2/6] staging: ft1000: space prohibited after '(', '&' and before ')' Chen Weixiang
2014-11-01 5:08 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 3/6] staging: ft1000: "(foo*)" should be "(foo *)" Chen Weixiang
2014-11-01 5:10 ` Sudip Mukherjee [this message]
2014-11-01 2:47 ` [PATCH v2 4/6] staging: ft1000: "foo * bar" should be "foo *bar" Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 5/6] staging: ft1000: else should follow close brace '}' Chen Weixiang
2014-11-01 5:12 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 6/6] staging: ft1000: space required after that ',' Chen Weixiang
2014-11-01 5:13 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101051031.GE3642@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=aybuke.147@gmail.com \
--cc=balbi@ti.com \
--cc=danieldodgese@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=nthery@gmail.com \
--cc=w-lkml@lebenslange-mailadresse.de \
--cc=weixiang.chen@gmail.com \
--cc=weixiangchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox