From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Chen Weixiang <weixiangchen@gmail.com>,
Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Felipe Balbi <balbi@ti.com>, Nicolas Thery <nthery@gmail.com>,
Greg Donald <gdonald@gmail.com>,
Daniel Dodge <danieldodgese@gmail.com>,
Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='
Date: Sat, 1 Nov 2014 21:59:38 +0530 [thread overview]
Message-ID: <20141101162938.GA22778@sudip-PC> (raw)
In-Reply-To: <20141101140939.GA8194@chenwx>
On Sat, Nov 01, 2014 at 10:09:39PM +0800, Chen Weixiang wrote:
> On Sat, Nov 01, 2014 at 10:35:35AM +0530, Sudip Mukherjee wrote:
> > many whitespace errors in the patch.
> > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
> >
> > thanks
> > sudip
> >
>
> Hi sudip,
>
> Yes, I also run checkpatch.pl on this patch, and got several
> errors/warnings. But those errors/warnings are not related to
> spaces around '=', '<' and '==' anymore.
>
> I thought it's better to fix one code style error/warning in
> one patch, and put the code style error/warning to Subject line.
> It's much clear, isn't it?
yes , it is . :)
i was also trying to generate a similar patch, which will not give checkpatch error,
but it seems the original file code indention is not done with tabs. so those errors will be there if you want to keep the same indention.
thanks
sudip
>
> Thanks.
>
> --
> Best regards,
> Chen Weixiang (Alex)
>
next prev parent reply other threads:[~2014-11-01 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 2:47 [PATCH v2 0/6] Remove checkpatch.pl errors from drivers/staging/ft1000 Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '==' Chen Weixiang
2014-11-01 5:05 ` Sudip Mukherjee
2014-11-01 5:14 ` Joe Perches
2014-11-01 5:25 ` Sudip Mukherjee
2014-11-01 5:30 ` Sudip Mukherjee
2014-11-01 5:47 ` Sudip Mukherjee
2014-11-01 14:51 ` Chen Weixiang
2014-11-01 14:09 ` Chen Weixiang
2014-11-01 16:29 ` Sudip Mukherjee [this message]
2014-11-04 0:05 ` Greg Kroah-Hartman
2014-11-10 0:16 ` Chen Weixiang
2014-11-10 1:00 ` Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 2/6] staging: ft1000: space prohibited after '(', '&' and before ')' Chen Weixiang
2014-11-01 5:08 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 3/6] staging: ft1000: "(foo*)" should be "(foo *)" Chen Weixiang
2014-11-01 5:10 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 4/6] staging: ft1000: "foo * bar" should be "foo *bar" Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 5/6] staging: ft1000: else should follow close brace '}' Chen Weixiang
2014-11-01 5:12 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 6/6] staging: ft1000: space required after that ',' Chen Weixiang
2014-11-01 5:13 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101162938.GA22778@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=aybuke.147@gmail.com \
--cc=balbi@ti.com \
--cc=danieldodgese@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=nthery@gmail.com \
--cc=w-lkml@lebenslange-mailadresse.de \
--cc=weixiangchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox