From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759557AbaKARvg (ORCPT ); Sat, 1 Nov 2014 13:51:36 -0400 Received: from mail.skyhub.de ([78.46.96.112]:39375 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbaKARvd (ORCPT ); Sat, 1 Nov 2014 13:51:33 -0400 Date: Sat, 1 Nov 2014 18:51:29 +0100 From: Borislav Petkov To: Steven Honeyman Cc: Joe Perches , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jiri Kosina , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86, cpu: trivial printk formatting fixes Message-ID: <20141101175129.GC4462@pd.tnic> References: <1414856696-8094-1-git-send-email-stevenhoneyman@gmail.com> <20141101171909.GA5034@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 01, 2014 at 05:38:18PM +0000, Steven Honeyman wrote: > On 1 November 2014 17:19, Borislav Petkov wrote: > > On Sat, Nov 01, 2014 at 03:44:56PM +0000, Steven Honeyman wrote: > >> A 2 line printk makes dmesg output messy, because the second line does not get a timestamp. > >> For example: > >> > >> [ 0.012863] CPU0: Thermal monitoring enabled (TM1) > >> [ 0.012869] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024 > >> Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4 > >> [ 0.012958] Freeing SMP alternatives memory: 28K (ffffffff81d86000 - ffffffff81d8d000) > >> [ 0.014961] dmar: Host address width 39 > > > > It looks just fine here, albeit with repeated timestamp: > > > > $ dmesg | grep -E "[id]TLB" > > [ 0.269607] Last level iTLB entries: 4KB 512, 2MB 1024, 4MB 512 > > [ 0.269607] Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 512, 1GB 0 > > That's strange! Is it the same for the other one? I just double dmesg | grep ENERGY [ 0.061976] ENERGY_PERF_BIAS: Set to 'normal', was 'performance' [ 0.061976] ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8) > checked on the slight chance I had an alias causing problems etc, but > that wasn't the case: > > $ 'dmesg'|'grep' ENERGY > [ 0.010557] ENERGY_PERF_BIAS: Set to 'normal', was 'performance' > ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8) > $ dmesg --version && grep --version > dmesg from util-linux 2.25.2 > grep (GNU grep) 2.20 $ dmesg --version && grep --version dmesg from util-linux 2.20.1 grep (GNU grep) 2.20 I've upgraged util-linux (for dmesg) on the other box: $ dmesg --version && grep --version dmesg from util-linux 2.25.1 grep (GNU grep) 2.18 and now I get: dmesg | grep -E "[id]TLB" [ 0.269607] Last level iTLB entries: 4KB 512, 2MB 1024, 4MB 512 Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 512, 1GB 0 So I'd say it looks like a regression in dmesg itself. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --