From: Kent Overstreet <kmo@daterainc.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org
Subject: Re: [PATCH] fix a leak in bch_cached_dev_run()
Date: Sat, 1 Nov 2014 13:38:16 -0700 [thread overview]
Message-ID: <20141101203816.GA22219@kmo-pixel> (raw)
In-Reply-To: <20141030054208.GE7996@ZenIV.linux.org.uk>
On Thu, Oct 30, 2014 at 05:42:09AM +0000, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -878,8 +878,11 @@ void bch_cached_dev_run(struct cached_dev *dc)
> buf[SB_LABEL_SIZE] = '\0';
> env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf);
>
> - if (atomic_xchg(&dc->running, 1))
> + if (atomic_xchg(&dc->running, 1)) {
> + kfree(env[1]);
> + kfree(env[2]);
> return;
> + }
>
> if (!d->c &&
> BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) {
Thanks, applied
prev parent reply other threads:[~2014-11-01 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 5:42 [PATCH] fix a leak in bch_cached_dev_run() Al Viro
2014-11-01 20:38 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101203816.GA22219@kmo-pixel \
--to=kmo@daterainc.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox