public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Tomasz Pala <gotar@polanet.pl>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org,
	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Subject: [PATCH] amd64_edac: Document why it is 64-bit only
Date: Sun, 2 Nov 2014 11:45:14 +0100	[thread overview]
Message-ID: <20141102104514.GC5229@pd.tnic> (raw)
In-Reply-To: <20141102103300.GB5229@pd.tnic>

On Sun, Nov 02, 2014 at 11:33:00AM +0100, Borislav Petkov wrote:
> I guess I'll add a note about this in the Kconfig text because I keep
> getting patches about this once every couple of months :-)

---
From: Borislav Petkov <bp@suse.de>
Subject: [PATCH] amd64_edac: Document why it is 64-bit only

I keep getting requests for this so let's hold it down why it doesn't
make sense. Also, drop incorrect statement about K8 and F10h - this
driver supports all relevant AMD CPUs.

Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 drivers/edac/Kconfig | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 7072c2892d63..4be205741221 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -105,11 +105,16 @@ config EDAC_GHES
 	  In doubt, say 'Y'.
 
 config EDAC_AMD64
-	tristate "AMD64 (Opteron, Athlon64) K8, F10h"
+	tristate "AMD64 (Opteron, Athlon64)"
 	depends on EDAC_MM_EDAC && AMD_NB && X86_64 && EDAC_DECODE_MCE
 	help
 	  Support for error detection and correction of DRAM ECC errors on
-	  the AMD64 families of memory controllers (K8 and F10h)
+	  the AMD64 families of memory controllers, everything >= K8.
+
+	  Note: this driver is 64-bit only on purpose because having a big
+	  driver report errors for 1 or 2 DIMMs max on 32-bit, considering
+	  current DIMM sizes, does not make a lot of sense to be worth the
+	  effort and energy.
 
 config EDAC_AMD64_ERROR_INJECTION
 	bool "Sysfs HW Error injection facilities"
-- 
2.0.0


-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-11-02 10:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 10:22 [PATCH] amd64_edac: Build module on x86-32 Tomasz Pala
2014-11-02 10:33 ` Borislav Petkov
2014-11-02 10:45   ` Borislav Petkov [this message]
2014-11-02 12:11   ` Tomasz Pala
2014-11-02 12:35     ` Borislav Petkov
2014-11-02 14:08       ` Tomasz Pala
2014-11-03 10:55         ` Borislav Petkov
2014-11-05 12:03           ` Tomasz Pala
2014-11-05 14:56             ` Borislav Petkov
2014-11-17 11:15               ` Tomasz Pala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141102104514.GC5229@pd.tnic \
    --to=bp@alien8.de \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=gotar@polanet.pl \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox