From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
Richard Weinberger <richard@nod.at>,
ceph-devel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] blk-mq: allow direct dispatch to a driver specific workqueue
Date: Mon, 3 Nov 2014 11:10:39 +0100 [thread overview]
Message-ID: <20141103101039.GA10128@lst.de> (raw)
In-Reply-To: <CACVXFVMrW-GSa1YMuvGx=vvxxP2ePwxvTAKzdyv=ZYh6yf+Z5g@mail.gmail.com>
On Mon, Nov 03, 2014 at 04:40:47PM +0800, Ming Lei wrote:
> The above two aren't enough because the big problem is that
> drivers need a per-request work structure instead of 'hctx->run_work',
> otherwise there are at most NR_CPUS concurrent submissions.
>
> So the per-request work structure should be exposed to blk-mq
> too for the kind of usage, such as .blk_mq_req_work(req) callback
> in case of BLK_MQ_F_WORKQUEUE.
Hmm. Maybe a better option is to just add a flag to never defer
->queue_rq to a workqueue and let drivers handle the it?
next prev parent reply other threads:[~2014-11-03 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 8:23 blk-mq: allow to defer ->queue_rq invocations to workqueue Christoph Hellwig
2014-11-03 8:23 ` [PATCH 1/2] blk-mq: handle single queue case in blk_mq_hctx_next_cpu Christoph Hellwig
2014-11-03 8:23 ` [PATCH 2/2] blk-mq: allow direct dispatch to a driver specific workqueue Christoph Hellwig
2014-11-03 8:40 ` Ming Lei
2014-11-03 10:10 ` Christoph Hellwig [this message]
2014-11-03 11:54 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103101039.GA10128@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox