From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbaKCM5k (ORCPT ); Mon, 3 Nov 2014 07:57:40 -0500 Received: from mail-ie0-f175.google.com ([209.85.223.175]:52142 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbaKCM5i (ORCPT ); Mon, 3 Nov 2014 07:57:38 -0500 Date: Mon, 3 Nov 2014 12:57:32 +0000 From: Lee Jones To: Linus Walleij Cc: Dmitry Torokhov , Samuel Ortiz , "linux-kernel@vger.kernel.org" , Linux Input Subject: Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE Message-ID: <20141103125732.GF4538@x1> References: <1413636974-3244-1-git-send-email-linus.walleij@linaro.org> <20141020064605.GB25349@x1> <58957675.Bh6LToE4gg@dtor-glaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Nov 2014, Linus Walleij wrote: > On Wed, Oct 29, 2014 at 8:31 PM, Dmitry Torokhov > wrote: > > On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote: > >> On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones wrote: > >> > On Sat, 18 Oct 2014, Linus Walleij wrote: > >> >> This adds the register offsets for pull up/down for the STMPE > >> >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines > >> >> and keypad lines. > >> >> > >> >> Signed-off-by: Linus Walleij > >> >> --- > >> >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the > >> >> patch series through the input tree, where the registers need to be > >> >> used to enable the keypad on the STMPE2401. > >> >> --- > >> >> > >> >> drivers/mfd/stmpe.c | 4 ++++ > >> >> drivers/mfd/stmpe.h | 3 +++ > >> >> include/linux/mfd/stmpe.h | 2 ++ > >> >> 3 files changed, 9 insertions(+) > >> > > >> > Does this need to go in with the other patches in the set? > >> > > >> > I'm _guessing_ that, as you've sent them separately, they can be > >> > applied separately? > >> > >> No sorry if it was unclear, the series need to go in toghether. > >> So this patch adds some infrastructure to the MFD device which > >> is then utilized by the input driver in a later patch. > >> > >> > This needs to go in via MFD, but for my own reference: > >> > > >> > Acked-by: Lee Jones > >> > >> Dmitry can you merge this & the rest with Lee's ACK? > > > > I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD? > > Lee, can Dmitry take these through input? That was weird, I replied at the same as as you sent this. Yes, it's fine. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog