From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
preeti@linux.vnet.ibm.com, Morten.Rasmussen@arm.com,
kamalesh@linux.vnet.ibm.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org, riel@redhat.com,
efault@gmx.de, nicolas.pitre@linaro.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v8 07/10] sched: replace capacity_factor by usage
Date: Mon, 3 Nov 2014 16:29:00 +0100 [thread overview]
Message-ID: <20141103152900.GJ12706@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1414745252-4895-8-git-send-email-vincent.guittot@linaro.org>
On Fri, Oct 31, 2014 at 09:47:29AM +0100, Vincent Guittot wrote:
> @@ -6414,11 +6399,12 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> */
> if (busiest->group_type == group_overloaded &&
> local->group_type == group_overloaded) {
> - load_above_capacity =
> - (busiest->sum_nr_running - busiest->group_capacity_factor);
> -
> - load_above_capacity *= (SCHED_LOAD_SCALE * SCHED_CAPACITY_SCALE);
> - load_above_capacity /= busiest->group_capacity;
> + load_above_capacity = busiest->sum_nr_running *
> + SCHED_LOAD_SCALE;
> + if (load_above_capacity > busiest->group_capacity)
> + load_above_capacity -= busiest->group_capacity;
> + else
> + load_above_capacity = ~0UL;
> }
>
> /*
It seems to me we no longer have need to assume each task contributes
SCHED_LOAD_SCALE, do we?
But as it stands I tihnk this patch already does too much -- it could do
with a splitting, but let me stare at is a wee bit more.
next prev parent reply other threads:[~2014-11-03 15:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 8:47 [PATCH v8 00/10] sched: consolidation of CPU capacity and usage Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 01/10] sched: add per rq cpu_capacity_orig Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 02/10] sched: remove frequency scaling from cpu_capacity Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 03/10] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2014-11-04 8:30 ` Wanpeng Li
2014-11-04 9:41 ` Vincent Guittot
2014-11-04 10:42 ` Wanpeng Li
2014-11-04 11:10 ` Vincent Guittot
2014-11-18 10:47 ` Wanpeng Li
2014-11-18 11:00 ` Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 04/10] sched: add utilization_avg_contrib Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 05/10] sched: Track group sched_entity usage contributions Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 06/10] sched: get CPU's usage statistic Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 07/10] sched: replace capacity_factor by usage Vincent Guittot
2014-11-03 7:01 ` Wanpeng Li
2014-11-03 10:59 ` Vincent Guittot
2014-11-03 15:29 ` Peter Zijlstra [this message]
2014-10-31 8:47 ` [PATCH v8 08/10] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot
2014-11-04 3:21 ` Wanpeng Li
2014-11-04 8:58 ` Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 09/10] sched: Make sched entity usage tracking scale-invariant Vincent Guittot
2014-10-31 8:47 ` [PATCH v8 10/10] sched: make scale_rt invariant with frequency Vincent Guittot
2014-11-03 15:51 ` Peter Zijlstra
2014-11-03 16:14 ` Vincent Guittot
2014-11-03 2:12 ` [PATCH v8 00/10] sched: consolidation of CPU capacity and usage Wanpeng Li
2014-11-03 10:55 ` Vincent Guittot
2014-11-03 13:03 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103152900.GJ12706@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=efault@gmx.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox