From: Lee Jones <lee.jones@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 06/11] wm8350-core: Fix probable mask then right shift defect
Date: Mon, 3 Nov 2014 18:02:18 +0000 [thread overview]
Message-ID: <20141103180218.GB13359@x1> (raw)
In-Reply-To: <9151d02031748dbc1637c1cc9110214617d9bcf1.1414387334.git.joe@perches.com>
On Sun, 26 Oct 2014, Joe Perches wrote:
> Precedence of & and >> is not the same and is not left to right.
> shift has higher precedence and should be done after the mask.
>
> Add parentheses around the mask.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/mfd/wm8350-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied with Charles' Ack.
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index 4ab527f..f5124a8 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -308,7 +308,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
> goto err;
> }
>
> - mode = id2 & WM8350_CONF_STS_MASK >> 10;
> + mode = (id2 & WM8350_CONF_STS_MASK) >> 10;
> cust_id = id2 & WM8350_CUST_ID_MASK;
> chip_rev = (id2 & WM8350_CHIP_REV_MASK) >> 12;
> dev_info(wm8350->dev,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-03 18:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 5:24 [PATCH 00/11] treewide: mask then shift defects and style updates Joe Perches
2014-10-27 5:24 ` [PATCH 01/11] block: nvme-scsi: Fix probable mask then right shift defects Joe Perches
2014-11-10 19:33 ` Verma, Vishal L
2014-10-27 5:24 ` [PATCH 02/11] radeon: evergreen: " Joe Perches
2014-10-27 9:14 ` Michel Dänzer
2014-10-27 14:14 ` [PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect Joe Perches
2014-10-28 3:42 ` Michel Dänzer
2014-10-28 14:06 ` Alex Deucher
2014-10-29 3:03 ` Michel Dänzer
2014-10-27 5:24 ` [PATCH 03/11] aiptek: Fix probable mask then right shift defects Joe Perches
2014-10-27 14:44 ` Dmitry Torokhov
2014-10-27 17:56 ` Joe Perches
2014-10-27 18:01 ` Dmitry Torokhov
2014-10-27 18:03 ` Joe Perches
2014-10-27 5:25 ` [PATCH 04/11] dvb-net: " Joe Perches
2014-10-27 5:25 ` [PATCH 05/11] cx25840/cx18: Use standard ordering of mask and shift Joe Perches
2014-11-08 13:41 ` Andy Walls
2014-10-27 5:25 ` [PATCH 06/11] wm8350-core: Fix probable mask then right shift defect Joe Perches
2014-10-27 12:47 ` Charles Keepax
2014-11-03 18:02 ` Lee Jones [this message]
2014-10-27 5:25 ` [PATCH 07/11] iwlwifi: dvm: " Joe Perches
2014-10-27 6:14 ` Grumbach, Emmanuel
2014-10-27 5:25 ` [PATCH 08/11] ssb: driver_chip_comon_pmu: " Joe Perches
2014-10-27 17:32 ` Michael Büsch
2014-10-27 5:25 ` [PATCH 09/11] tty: ipwireless: Fix probable mask then right shift defects Joe Perches
2014-10-27 13:18 ` David Sterba
2014-10-27 14:17 ` Jiri Kosina
2014-10-28 1:57 ` Greg Kroah-Hartman
2014-10-27 5:25 ` [PATCH 10/11] hwa-hc: Fix probable mask then right shift defect Joe Perches
2014-10-27 5:25 ` [PATCH 11/11] sound: ad1889: Fix probable mask then right shift defects Joe Perches
2014-10-27 7:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103180218.GB13359@x1 \
--to=lee.jones@linaro.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox