Re: [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding

Mark Brown
2014-10-07T12:52:47Z

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Tue, Oct 07, 2014 at 02:11:07PM +0900, Gyungoh Yoo wrote:
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>

Several problems here:

- I don't have patches 1-6 or the cover letter for this series - what
are the dependencies?
- I can't see any sign that my concerns about the driver not actually
being reusable have been addressed here.
- This patch appears to do way more than add a compatible string, for
example:

> - np = of_get_child_by_name(dev->parent->of_node, "regulator");
> - if (unlikely(!np)) {
> + if (!np) {
> dev_err(dev, "regulator node not found");
> - return NULL;
> + return ERR_PTR(-ENODATA);

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]