From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Kirill Tkhai <ktkhai@parallels.com>,
Juri Lelli <juri.lelli@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug
Date: Tue, 4 Nov 2014 09:32:25 +0100 [thread overview]
Message-ID: <20141104083225.GG10501@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20141103235747.GA26702@kernel>
On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote:
> On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote:
> >On Fri, Oct 31, 2014 at 03:28:17PM +0800, Wanpeng Li wrote:
> >So what is wrong with making dl_task_timer() deal with it? The timer
> >will still fire on the correct time, canceling it and or otherwise
> >messing with the CBS is wrong. Once it fires, all we need to do is
> >migrate it to another cpu (preferably one that is still online of course
> >:-).
> Do you mean what I need to do is push the task to another cpu in dl_task_timer()
> if rq is offline?
That does indeed appear to be the sensible fix to me.
> In addition, what will happen if dl task can't preempt on
> another cpu?
So if we find that the rq the task was on is no longer available, we
need to select a new rq, the 'right' rq would be the one running the
latest deadline.
If it cannot preempt the latest (running) deadline, it was not eligible
for running in the first place so no worries, right?
next prev parent reply other threads:[~2014-11-04 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1414740497-7232-1-git-send-email-wanpeng.li@linux.intel.com>
[not found] ` <1414747229.8574.99.camel@tkhai>
2014-11-03 2:03 ` [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug Wanpeng Li
[not found] ` <5453759F.5020803@arm.com>
2014-11-03 2:16 ` Wanpeng Li
[not found] ` <20141103104111.GA23531@worktop.programming.kicks-ass.net>
2014-11-03 23:57 ` Wanpeng Li
2014-11-04 8:32 ` Peter Zijlstra [this message]
2014-11-04 8:23 ` Wanpeng Li
2014-11-04 9:20 ` Juri Lelli
2014-11-04 10:10 ` Peter Zijlstra
2014-11-04 10:51 ` Wanpeng Li
2014-11-04 13:30 ` Wanpeng Li
2014-11-04 13:33 ` Wanpeng Li
2014-11-04 15:46 ` Peter Zijlstra
2014-11-04 15:50 ` Juri Lelli
2014-11-05 6:24 ` Wanpeng Li
2014-10-31 23:21 Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104083225.GG10501@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@arm.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox