* [PATCH] mfd: lpc_sch: don't call mfd_remove_devices()
@ 2014-11-03 17:29 Andy Shevchenko
2014-11-04 9:10 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2014-11-03 17:29 UTC (permalink / raw)
To: linux-kernel, Lee Jones; +Cc: Andy Shevchenko
MFD core already cares about failing registration. It will remove successfully
registered devices in case of error. Thus, no need to repeatedly call
mfd_remove_devices().
Fixes: 5829e9b64e65 (mfd: lpc_sch: Accomodate partial population of the MFD devices)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/lpc_sch.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mfd/lpc_sch.c b/drivers/mfd/lpc_sch.c
index c980da4..5c38df3 100644
--- a/drivers/mfd/lpc_sch.c
+++ b/drivers/mfd/lpc_sch.c
@@ -193,11 +193,7 @@ static int lpc_sch_probe(struct pci_dev *dev, const struct pci_device_id *id)
return -ENODEV;
}
- ret = mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
- if (ret)
- mfd_remove_devices(&dev->dev);
-
- return ret;
+ return mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
}
static void lpc_sch_remove(struct pci_dev *dev)
--
2.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: lpc_sch: don't call mfd_remove_devices()
2014-11-03 17:29 [PATCH] mfd: lpc_sch: don't call mfd_remove_devices() Andy Shevchenko
@ 2014-11-04 9:10 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-11-04 9:10 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel
On Mon, 03 Nov 2014, Andy Shevchenko wrote:
> MFD core already cares about failing registration. It will remove successfully
> registered devices in case of error. Thus, no need to repeatedly call
> mfd_remove_devices().
>
> Fixes: 5829e9b64e65 (mfd: lpc_sch: Accomodate partial population of the MFD devices)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/lpc_sch.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lpc_sch.c b/drivers/mfd/lpc_sch.c
> index c980da4..5c38df3 100644
> --- a/drivers/mfd/lpc_sch.c
> +++ b/drivers/mfd/lpc_sch.c
> @@ -193,11 +193,7 @@ static int lpc_sch_probe(struct pci_dev *dev, const struct pci_device_id *id)
> return -ENODEV;
> }
>
> - ret = mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
> - if (ret)
> - mfd_remove_devices(&dev->dev);
> -
> - return ret;
> + return mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
> }
>
> static void lpc_sch_remove(struct pci_dev *dev)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-04 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 17:29 [PATCH] mfd: lpc_sch: don't call mfd_remove_devices() Andy Shevchenko
2014-11-04 9:10 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox