From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Kirill Tkhai <ktkhai@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: fix use stale overloaded status to find busiest group
Date: Tue, 4 Nov 2014 11:52:03 +0100 [thread overview]
Message-ID: <20141104105203.GM3337@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1415079056-8679-1-git-send-email-wanpeng.li@linux.intel.com>
On Tue, Nov 04, 2014 at 01:30:56PM +0800, Wanpeng Li wrote:
> Commit caeb178c60f4 ("sched/fair: Make update_sd_pick_busiest() return
> 'true' on a busier sd") makes groups are ranked in the order overloaded >
> imbalance > other and busiest group is picked according to this order.
> sgs->group_capacity_factor is used to check if group is overloaded. In
> the case of the child domain prefers tasks go to siblings first, the
> sgs->group_capacity_factor will be set lower to one in order to move all
> the excess tasks away. However, group overloaded status is not updated
> in the case of sgs->group_capacity_factor be set lower to one which
> leads to miss find the busiest group. This patch fix it by updating
> group overloaded status in the case of sg capacity factor is set to
> one in order to find busiest group accurately.
You noticed this while going over Vincents patches, right?
Also, try and introduce some newlines in the changelog, paragraphs of
3-5 lines are best.
next prev parent reply other threads:[~2014-11-04 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 5:30 [PATCH] sched/fair: fix use stale overloaded status to find busiest group Wanpeng Li
2014-11-04 10:52 ` Peter Zijlstra [this message]
2014-11-04 11:08 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104105203.GM3337@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=riel@redhat.com \
--cc=vincent.guittot@linaro.org \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox