From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com
Subject: Re: [PATCH] goldfish: fixed sparse warning
Date: Tue, 4 Nov 2014 19:37:12 +0530 [thread overview]
Message-ID: <20141104140712.GA8334@sudip-PC> (raw)
In-Reply-To: <1412949525-17561-1-git-send-email-sudipm.mukherjee@gmail.com>
On Fri, Oct 10, 2014 at 07:28:45PM +0530, Sudip Mukherjee wrote:
> fixed sparse warning of Using plain integer as NULL pointer
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/tty/goldfish.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
> index 09495f5..c24b963 100644
> --- a/drivers/tty/goldfish.c
> +++ b/drivers/tty/goldfish.c
> @@ -157,7 +157,7 @@ static int goldfish_tty_console_setup(struct console *co, char *options)
> {
> if ((unsigned)co->index > goldfish_tty_line_count)
> return -ENODEV;
> - if (goldfish_ttys[co->index].base == 0)
> + if (!goldfish_ttys[co->index].base)
> return -ENODEV;
> return 0;
> }
> @@ -317,7 +317,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
> unregister_console(&qtty->console);
> tty_unregister_device(goldfish_tty_driver, pdev->id);
> iounmap(qtty->base);
> - qtty->base = 0;
> + qtty->base = NULL;
> free_irq(qtty->irq, pdev);
> goldfish_tty_current_line_count--;
> if (goldfish_tty_current_line_count == 0)
> --
> 1.8.1.2
>
a gentle ping
thanks
sudip
next prev parent reply other threads:[~2014-11-04 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 13:58 [PATCH] goldfish: fixed sparse warning Sudip Mukherjee
2014-11-04 14:07 ` Sudip Mukherjee [this message]
2014-11-06 0:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104140712.GA8334@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox