* [PATCH] goldfish: fixed sparse warning
@ 2014-10-10 13:58 Sudip Mukherjee
2014-11-04 14:07 ` Sudip Mukherjee
2014-11-06 0:12 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2014-10-10 13:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby; +Cc: Sudip Mukherjee, linux-kernel, alan
fixed sparse warning of Using plain integer as NULL pointer
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/tty/goldfish.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index 09495f5..c24b963 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -157,7 +157,7 @@ static int goldfish_tty_console_setup(struct console *co, char *options)
{
if ((unsigned)co->index > goldfish_tty_line_count)
return -ENODEV;
- if (goldfish_ttys[co->index].base == 0)
+ if (!goldfish_ttys[co->index].base)
return -ENODEV;
return 0;
}
@@ -317,7 +317,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
unregister_console(&qtty->console);
tty_unregister_device(goldfish_tty_driver, pdev->id);
iounmap(qtty->base);
- qtty->base = 0;
+ qtty->base = NULL;
free_irq(qtty->irq, pdev);
goldfish_tty_current_line_count--;
if (goldfish_tty_current_line_count == 0)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] goldfish: fixed sparse warning
2014-10-10 13:58 [PATCH] goldfish: fixed sparse warning Sudip Mukherjee
@ 2014-11-04 14:07 ` Sudip Mukherjee
2014-11-06 0:12 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2014-11-04 14:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby; +Cc: linux-kernel, alan
On Fri, Oct 10, 2014 at 07:28:45PM +0530, Sudip Mukherjee wrote:
> fixed sparse warning of Using plain integer as NULL pointer
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/tty/goldfish.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
> index 09495f5..c24b963 100644
> --- a/drivers/tty/goldfish.c
> +++ b/drivers/tty/goldfish.c
> @@ -157,7 +157,7 @@ static int goldfish_tty_console_setup(struct console *co, char *options)
> {
> if ((unsigned)co->index > goldfish_tty_line_count)
> return -ENODEV;
> - if (goldfish_ttys[co->index].base == 0)
> + if (!goldfish_ttys[co->index].base)
> return -ENODEV;
> return 0;
> }
> @@ -317,7 +317,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
> unregister_console(&qtty->console);
> tty_unregister_device(goldfish_tty_driver, pdev->id);
> iounmap(qtty->base);
> - qtty->base = 0;
> + qtty->base = NULL;
> free_irq(qtty->irq, pdev);
> goldfish_tty_current_line_count--;
> if (goldfish_tty_current_line_count == 0)
> --
> 1.8.1.2
>
a gentle ping
thanks
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] goldfish: fixed sparse warning
2014-10-10 13:58 [PATCH] goldfish: fixed sparse warning Sudip Mukherjee
2014-11-04 14:07 ` Sudip Mukherjee
@ 2014-11-06 0:12 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-11-06 0:12 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Jiri Slaby, linux-kernel, alan
On Fri, Oct 10, 2014 at 07:28:45PM +0530, Sudip Mukherjee wrote:
> fixed sparse warning of Using plain integer as NULL pointer
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/tty/goldfish.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
> index 09495f5..c24b963 100644
> --- a/drivers/tty/goldfish.c
> +++ b/drivers/tty/goldfish.c
> @@ -157,7 +157,7 @@ static int goldfish_tty_console_setup(struct console *co, char *options)
> {
> if ((unsigned)co->index > goldfish_tty_line_count)
> return -ENODEV;
> - if (goldfish_ttys[co->index].base == 0)
> + if (!goldfish_ttys[co->index].base)
> return -ENODEV;
> return 0;
> }
> @@ -317,7 +317,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
> unregister_console(&qtty->console);
> tty_unregister_device(goldfish_tty_driver, pdev->id);
> iounmap(qtty->base);
> - qtty->base = 0;
> + qtty->base = NULL;
> free_irq(qtty->irq, pdev);
> goldfish_tty_current_line_count--;
> if (goldfish_tty_current_line_count == 0)
> --
> 1.8.1.2
Sorry, but someone else sent this same patch before you did :(
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-06 0:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 13:58 [PATCH] goldfish: fixed sparse warning Sudip Mukherjee
2014-11-04 14:07 ` Sudip Mukherjee
2014-11-06 0:12 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox