[PATCH] usb: dwc3: remove warning of disable scramble check

[PATCH] usb: dwc3: remove warning of disable scramble check

[Huang Rui]

Some SoC's FPGA platform will need this quirk, but it will complain if
running at true SoC platform. This is a normal case, so remove this
warning.

Signed-off-by: Huang Rui <ray.huang@amd.com>
---

Hi,

This patch is based on balbi/testing/next branch.

Thanks,
Rui

---
 drivers/usb/dwc3/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 8ae42b8..3f1f0ab 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -531,9 +531,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 		dwc->is_fpga = true;
 	}
 
-	WARN_ONCE(dwc->disable_scramble_quirk && !dwc->is_fpga,
-			"disable_scramble cannot be used on non-FPGA builds\n");
-
 	if (dwc->disable_scramble_quirk && dwc->is_fpga)
 		reg |= DWC3_GCTL_DISSCRAMBLE;
 	else
-- 
1.9.1

Re: [PATCH] usb: dwc3: remove warning of disable scramble check

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

On Tue, Nov 04, 2014 at 05:29:51PM +0800, Huang Rui wrote:
> Some SoC's FPGA platform will need this quirk, but it will complain if
> running at true SoC platform. This is a normal case, so remove this
> warning.

nope, why do you need disable_scramble on actual SoC ? Without an
erratum number I will not accept this, sorry.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] usb: dwc3: remove warning of disable scramble check

[Huang Rui]

On Tue, Nov 04, 2014 at 08:47:26AM -0600, Felipe Balbi wrote:
> On Tue, Nov 04, 2014 at 05:29:51PM +0800, Huang Rui wrote:
> > Some SoC's FPGA platform will need this quirk, but it will complain if
> > running at true SoC platform. This is a normal case, so remove this
> > warning.
> 
> nope, why do you need disable_scramble on actual SoC ? Without an
> erratum number I will not accept this, sorry.
> 

Oh, that's my faulty. I can set disable_scramble_quirk=false after
actual SoC, at that time, we can drop FPGA support. :)

Thanks,
Rui

Re: [PATCH] usb: dwc3: remove warning of disable scramble check

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On Wed, Nov 05, 2014 at 12:39:51PM +0800, Huang Rui wrote:
> On Tue, Nov 04, 2014 at 08:47:26AM -0600, Felipe Balbi wrote:
> > On Tue, Nov 04, 2014 at 05:29:51PM +0800, Huang Rui wrote:
> > > Some SoC's FPGA platform will need this quirk, but it will complain if
> > > running at true SoC platform. This is a normal case, so remove this
> > > warning.
> > 
> > nope, why do you need disable_scramble on actual SoC ? Without an
> > erratum number I will not accept this, sorry.
> > 
> 
> Oh, that's my faulty. I can set disable_scramble_quirk=false after
> actual SoC, at that time, we can drop FPGA support. :)

correct, thank you

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]