public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Wanpeng Li <wanpeng.li@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Kirill Tkhai <ktkhai@parallels.com>,
	Juri Lelli <juri.lelli@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug
Date: Tue, 4 Nov 2014 16:46:23 +0100	[thread overview]
Message-ID: <20141104154623.GK10501@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <5458D506.4080702@gmail.com>

On Tue, Nov 04, 2014 at 09:30:46PM +0800, Wanpeng Li wrote:


> + if (!rq->online) {
> + struct rq *latest_rq = NULL;
> + int cpu;
> + u64 dmin = LONG_MAX;
> +
> + for_each_cpu(cpu, &p->cpus_allowed)
> + if (cpu_online(cpu) &&
> + cpu_rq(cpu)->dl.earliest_dl.curr < dmin) {
> + latest_rq = cpu_rq(cpu);
> + dmin = latest_rq->dl.earliest_dl.curr;
> + }

I would have expected something using find_later_rq(), but I might be
mistaken, I'll let Juri suggest something.

> +
> + if (!latest_rq)
> + goto unlock;
> +
> + raw_spin_lock(&latest_rq->lock);
> +
> + deactivate_task(rq, p, 0);
> + set_task_cpu(p, latest_rq->cpu);
> + activate_task(latest_rq, p, 0);
> +
> + raw_spin_unlock(&latest_rq->lock);
> + }
> +
> unlock:
> raw_spin_unlock(&rq->lock);

  parent reply	other threads:[~2014-11-04 15:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1414740497-7232-1-git-send-email-wanpeng.li@linux.intel.com>
     [not found] ` <1414747229.8574.99.camel@tkhai>
2014-11-03  2:03   ` [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug Wanpeng Li
     [not found] ` <5453759F.5020803@arm.com>
2014-11-03  2:16   ` Wanpeng Li
     [not found] ` <20141103104111.GA23531@worktop.programming.kicks-ass.net>
2014-11-03 23:57   ` Wanpeng Li
2014-11-04  8:32     ` Peter Zijlstra
2014-11-04  8:23       ` Wanpeng Li
2014-11-04  9:20         ` Juri Lelli
2014-11-04 10:10         ` Peter Zijlstra
2014-11-04 10:51           ` Wanpeng Li
2014-11-04 13:30           ` Wanpeng Li
2014-11-04 13:33             ` Wanpeng Li
2014-11-04 15:46             ` Peter Zijlstra [this message]
2014-11-04 15:50               ` Juri Lelli
2014-11-05  6:24                 ` Wanpeng Li
2014-10-31 23:21 Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141104154623.GK10501@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=juri.lelli@arm.com \
    --cc=kernellwp@gmail.com \
    --cc=ktkhai@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox