public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>,
	Gulsah Kose <gulsah.1004@gmail.com>,
	Matina Maria Trompouki <mtrompou@gmail.com>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: lirc: modify print calls
Date: Wed, 5 Nov 2014 08:17:11 -0200	[thread overview]
Message-ID: <20141105081711.4c6abcc3@recife.lan> (raw)
In-Reply-To: <20141104214307.GA6709@localhost.localdomain>

Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> escreveu:

> This patches replaces one pr_debug call by dev_dbg and
> changes the device used by one of the dev_err calls.

Also doesn't apply. Probably made to apply on Greg's tree.

Regards,
Mauro

> 
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> index 52f8e91..dca806a 100644
> --- a/drivers/staging/media/lirc/lirc_zilog.c
> +++ b/drivers/staging/media/lirc/lirc_zilog.c
> @@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  	int ret;
>  	bool tx_probe = false;
>  
> -	pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> +	dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
>  		__func__, id->name, adap->nr, adap->name, client->addr);
>  
>  	/*
> @@ -1631,7 +1631,7 @@ out_put_xx:
>  out_put_ir:
>  	put_ir_device(ir, true);
>  out_no_ir:
> -	dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> +	dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
>  		    __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
>  		   ret);
>  	mutex_unlock(&ir_devices_lock);

  reply	other threads:[~2014-11-05 10:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 21:43 [PATCH] staging: media: lirc: modify print calls Aya Mahfouz
2014-11-05 10:17 ` Mauro Carvalho Chehab [this message]
2014-11-05 13:43   ` Aya Mahfouz
2014-11-05 16:29     ` Greg Kroah-Hartman
2014-11-05 11:29 ` Sudip Mukherjee
2014-11-05 13:40   ` Aya Mahfouz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105081711.4c6abcc3@recife.lan \
    --to=mchehab@osg.samsung.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gulsah.1004@gmail.com \
    --cc=jarod@wilsonet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mahfouz.saif.elyazal@gmail.com \
    --cc=mtrompou@gmail.com \
    --cc=tuomas.tynkkynen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox