* [PATCH] staging: media: lirc: modify print calls
@ 2014-11-04 21:43 Aya Mahfouz
2014-11-05 10:17 ` Mauro Carvalho Chehab
2014-11-05 11:29 ` Sudip Mukherjee
0 siblings, 2 replies; 6+ messages in thread
From: Aya Mahfouz @ 2014-11-04 21:43 UTC (permalink / raw)
To: Jarod Wilson, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Dan Carpenter, Tuomas Tynkkynen, Gulsah Kose,
Matina Maria Trompouki
Cc: linux-media, devel, linux-kernel
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
---
drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
index 52f8e91..dca806a 100644
--- a/drivers/staging/media/lirc/lirc_zilog.c
+++ b/drivers/staging/media/lirc/lirc_zilog.c
@@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
int ret;
bool tx_probe = false;
- pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
+ dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
__func__, id->name, adap->nr, adap->name, client->addr);
/*
@@ -1631,7 +1631,7 @@ out_put_xx:
out_put_ir:
put_ir_device(ir, true);
out_no_ir:
- dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
+ dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
__func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
ret);
mutex_unlock(&ir_devices_lock);
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: media: lirc: modify print calls
2014-11-04 21:43 [PATCH] staging: media: lirc: modify print calls Aya Mahfouz
@ 2014-11-05 10:17 ` Mauro Carvalho Chehab
2014-11-05 13:43 ` Aya Mahfouz
2014-11-05 11:29 ` Sudip Mukherjee
1 sibling, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2014-11-05 10:17 UTC (permalink / raw)
To: Aya Mahfouz
Cc: Jarod Wilson, Greg Kroah-Hartman, Dan Carpenter, Tuomas Tynkkynen,
Gulsah Kose, Matina Maria Trompouki, linux-media, devel,
linux-kernel
Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> escreveu:
> This patches replaces one pr_debug call by dev_dbg and
> changes the device used by one of the dev_err calls.
Also doesn't apply. Probably made to apply on Greg's tree.
Regards,
Mauro
>
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> ---
> drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> index 52f8e91..dca806a 100644
> --- a/drivers/staging/media/lirc/lirc_zilog.c
> +++ b/drivers/staging/media/lirc/lirc_zilog.c
> @@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
> int ret;
> bool tx_probe = false;
>
> - pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> + dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> __func__, id->name, adap->nr, adap->name, client->addr);
>
> /*
> @@ -1631,7 +1631,7 @@ out_put_xx:
> out_put_ir:
> put_ir_device(ir, true);
> out_no_ir:
> - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> + dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
> ret);
> mutex_unlock(&ir_devices_lock);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: media: lirc: modify print calls
2014-11-05 10:17 ` Mauro Carvalho Chehab
@ 2014-11-05 13:43 ` Aya Mahfouz
2014-11-05 16:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Aya Mahfouz @ 2014-11-05 13:43 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Jarod Wilson, Greg Kroah-Hartman, Dan Carpenter, Tuomas Tynkkynen,
Gulsah Kose, Matina Maria Trompouki, linux-media, devel,
linux-kernel
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
> Em Tue, 4 Nov 2014 23:43:07 +0200
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> escreveu:
>
> > This patches replaces one pr_debug call by dev_dbg and
> > changes the device used by one of the dev_err calls.
>
> Also doesn't apply. Probably made to apply on Greg's tree.
>
> Regards,
> Mauro
>
Yes, I submit patches to Greg's tree. Should I clone your
tree?
Kind Regards,
Aya Saif El-yazal Mahfouz
> >
> > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > ---
> > drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> > index 52f8e91..dca806a 100644
> > --- a/drivers/staging/media/lirc/lirc_zilog.c
> > +++ b/drivers/staging/media/lirc/lirc_zilog.c
> > @@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
> > int ret;
> > bool tx_probe = false;
> >
> > - pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> > + dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> > __func__, id->name, adap->nr, adap->name, client->addr);
> >
> > /*
> > @@ -1631,7 +1631,7 @@ out_put_xx:
> > out_put_ir:
> > put_ir_device(ir, true);
> > out_no_ir:
> > - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > + dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
> > ret);
> > mutex_unlock(&ir_devices_lock);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: media: lirc: modify print calls
2014-11-05 13:43 ` Aya Mahfouz
@ 2014-11-05 16:29 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2014-11-05 16:29 UTC (permalink / raw)
To: Aya Mahfouz
Cc: Mauro Carvalho Chehab, devel, Gulsah Kose, Jarod Wilson,
linux-kernel, Tuomas Tynkkynen, Matina Maria Trompouki,
Dan Carpenter, linux-media
On Wed, Nov 05, 2014 at 03:43:44PM +0200, Aya Mahfouz wrote:
> On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
> > Em Tue, 4 Nov 2014 23:43:07 +0200
> > Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> escreveu:
> >
> > > This patches replaces one pr_debug call by dev_dbg and
> > > changes the device used by one of the dev_err calls.
> >
> > Also doesn't apply. Probably made to apply on Greg's tree.
> >
> > Regards,
> > Mauro
> >
>
> Yes, I submit patches to Greg's tree. Should I clone your
> tree?
I'll take this one as it builds on a change in my tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: media: lirc: modify print calls
2014-11-04 21:43 [PATCH] staging: media: lirc: modify print calls Aya Mahfouz
2014-11-05 10:17 ` Mauro Carvalho Chehab
@ 2014-11-05 11:29 ` Sudip Mukherjee
2014-11-05 13:40 ` Aya Mahfouz
1 sibling, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2014-11-05 11:29 UTC (permalink / raw)
To: Aya Mahfouz
Cc: Jarod Wilson, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Dan Carpenter, Tuomas Tynkkynen, Gulsah Kose,
Matina Maria Trompouki, linux-media, devel, linux-kernel
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
> This patches replaces one pr_debug call by dev_dbg and
> changes the device used by one of the dev_err calls.
i think you should mention in the commit message why you are changing the device.
and also for revised patch its better if you add version number in the subject.
like this is v2.
thanks
sudip
>
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> ---
> drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> index 52f8e91..dca806a 100644
> --- a/drivers/staging/media/lirc/lirc_zilog.c
> +++ b/drivers/staging/media/lirc/lirc_zilog.c
> @@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
> int ret;
> bool tx_probe = false;
>
> - pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> + dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> __func__, id->name, adap->nr, adap->name, client->addr);
>
> /*
> @@ -1631,7 +1631,7 @@ out_put_xx:
> out_put_ir:
> put_ir_device(ir, true);
> out_no_ir:
> - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> + dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
> ret);
> mutex_unlock(&ir_devices_lock);
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: media: lirc: modify print calls
2014-11-05 11:29 ` Sudip Mukherjee
@ 2014-11-05 13:40 ` Aya Mahfouz
0 siblings, 0 replies; 6+ messages in thread
From: Aya Mahfouz @ 2014-11-05 13:40 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Jarod Wilson, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Dan Carpenter, Tuomas Tynkkynen, Gulsah Kose,
Matina Maria Trompouki, linux-media, devel, linux-kernel
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote:
> On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
> > This patches replaces one pr_debug call by dev_dbg and
> > changes the device used by one of the dev_err calls.
>
> i think you should mention in the commit message why you are changing the device.
> and also for revised patch its better if you add version number in the subject.
> like this is v2.
>
> thanks
> sudip
>
Thanks Sudip for your feedback. I use versions if I keep the same subject.
Kind Regards,
Aya Saif El-yazal Mahfouz
> >
> > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > ---
> > drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> > index 52f8e91..dca806a 100644
> > --- a/drivers/staging/media/lirc/lirc_zilog.c
> > +++ b/drivers/staging/media/lirc/lirc_zilog.c
> > @@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
> > int ret;
> > bool tx_probe = false;
> >
> > - pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> > + dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
> > __func__, id->name, adap->nr, adap->name, client->addr);
> >
> > /*
> > @@ -1631,7 +1631,7 @@ out_put_xx:
> > out_put_ir:
> > put_ir_device(ir, true);
> > out_no_ir:
> > - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > + dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
> > ret);
> > mutex_unlock(&ir_devices_lock);
> > --
> > 1.9.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-05 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04 21:43 [PATCH] staging: media: lirc: modify print calls Aya Mahfouz
2014-11-05 10:17 ` Mauro Carvalho Chehab
2014-11-05 13:43 ` Aya Mahfouz
2014-11-05 16:29 ` Greg Kroah-Hartman
2014-11-05 11:29 ` Sudip Mukherjee
2014-11-05 13:40 ` Aya Mahfouz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox