From: Johannes Thumshirn <johannes.thumshirn@men.de>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Johannes Thumshirn <johannes.thumshirn@men.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] tty: serial: men_z135_uart: Fix driver for changes in hardware
Date: Wed, 5 Nov 2014 17:39:53 +0100 [thread overview]
Message-ID: <20141105163952.GA21159@jtlinux> (raw)
In-Reply-To: <5457F30F.2030203@hurleysoftware.com>
On Mon, Nov 03, 2014 at 04:26:39PM -0500, Peter Hurley wrote:
> On 11/03/2014 04:01 PM, Peter Hurley wrote:
> > On 11/03/2014 11:05 AM, Johannes Thumshirn wrote:
> >> * Enable the handling of UART core's automatic flow control feature.
> >> When AFE is active disable generation of modem status IRQs.
> >
> > So HUPCL doesn't work when CRTSCTS is set?
>
> Sorry, I meant !CLOCAL. IOW,
>
> 'So !CLOCAL doesn't work when CRTSCTS is set?'
Yes, unfortunately
>
> > Is this because there's actually a problem with the IP core that
> > MSIs trash the autoCTS state, or is the problem that the driver
> > just shouldn't be calling uart_handle_cts_change() when autoCTS is
> > on?
>
>From our investigations it looks like it trashes the autoCTS state.
Johannes
next prev parent reply other threads:[~2014-11-05 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 16:05 [PATCH v4] tty: serial: men_z135_uart: Fix driver for changes in hardware Johannes Thumshirn
2014-11-03 21:01 ` Peter Hurley
2014-11-03 21:26 ` Peter Hurley
2014-11-05 16:39 ` Johannes Thumshirn [this message]
2014-11-05 17:10 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105163952.GA21159@jtlinux \
--to=johannes.thumshirn@men.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox