From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751302AbaKFQMR (ORCPT ); Thu, 6 Nov 2014 11:12:17 -0500 Received: from mail-qg0-f42.google.com ([209.85.192.42]:48973 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbaKFQMP (ORCPT ); Thu, 6 Nov 2014 11:12:15 -0500 Date: Thu, 6 Nov 2014 11:12:11 -0500 From: Tejun Heo To: Michal Hocko Cc: "Rafael J. Wysocki" , Andrew Morton , Cong Wang , David Rientjes , Oleg Nesterov , LKML , linux-mm@kvack.org, Linux PM list Subject: Re: [PATCH 3/4] OOM, PM: OOM killed task shouldn't escape PM suspend Message-ID: <20141106161211.GC25642@htj.dyndns.org> References: <20141105134219.GD4527@dhcp22.suse.cz> <20141105154436.GB14386@htj.dyndns.org> <20141105160115.GA28226@dhcp22.suse.cz> <20141105162929.GD14386@htj.dyndns.org> <20141105163956.GD28226@dhcp22.suse.cz> <20141105165428.GF14386@htj.dyndns.org> <20141105170111.GG14386@htj.dyndns.org> <20141106130543.GE7202@dhcp22.suse.cz> <20141106150927.GB25642@htj.dyndns.org> <20141106160158.GI7202@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141106160158.GI7202@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 06, 2014 at 05:01:58PM +0100, Michal Hocko wrote: > Yes, OOM killer simply kicks the process sets TIF_MEMDIE and terminates. > That will release the read_lock, allow this to take the write lock and > check whether it the current has been killed without any races. > OOM killer doesn't wait for the killed task. The allocation is retried. > > Does this explain your concern? Draining oom killer then doesn't mean anything, no? OOM killer may have been disabled and drained but the killed tasks might wake up after the PM freezer considers them to be frozen, right? What am I missing? -- tejun