From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kris@konagma.com
Cc: navin.patidar@gmail.com, Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtl8188eu: Fix several stylistic problems in rtw_led.*
Date: Thu, 6 Nov 2014 15:03:58 -0800 [thread overview]
Message-ID: <20141106230358.GA12437@kroah.com> (raw)
In-Reply-To: <1415314565-9552-1-git-send-email-kris@konagma.com>
On Thu, Nov 06, 2014 at 11:56:05PM +0100, kris@konagma.com wrote:
> From: Krzysztof Konopko <kris@konagma.com>
>
> Several stylistics problems are reported by scripts/checkpatch.pl run on
> rtw_led.*:
>
> * FSF_MAILING_ADDRESS
>
> Free Software Foundation's mailing address should not be included in
> the sample GPL notice.
>
> * LINE_SPACING
>
> Missing a blank line after declarations.
>
> * leading spaces
>
> * a typo
>
> * any too long lines changed with this patch
>
> All of the problems above are fixed with this patch.
Each patch should only do 1 thing, so please break this up into multiple
patches, each only doing 1 thing, in a patch series, and resend so it
can be applied.
thanks,
greg k-h
prev parent reply other threads:[~2014-11-06 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 22:56 [PATCH] rtl8188eu: Fix several stylistic problems in rtw_led.* kris
2014-11-06 23:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106230358.GA12437@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kris@konagma.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navin.patidar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox