From: Josh Triplett <josh@joshtriplett.org>
To: Aristeu Rozanski <aris@redhat.com>
Cc: Dave Hansen <dave@sr71.net>,
linux-kernel@vger.kernel.org, Changli Gao <xiaosuo@gmail.com>,
David Rientjes <rientjes@google.com>,
Eric Paris <eparis@redhat.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Jesse Gross <jesse@nicira.com>, Jonathan Corbet <corbet@lwn.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Pravin Shelar <pshelar@nicira.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] lib/flex_array: make build optional
Date: Thu, 6 Nov 2014 19:31:02 -0800 [thread overview]
Message-ID: <20141107033102.GB7249@thin> (raw)
In-Reply-To: <20141106215056.GK26472@redhat.com>
On Thu, Nov 06, 2014 at 04:50:56PM -0500, Aristeu Rozanski wrote:
> On Thu, Nov 06, 2014 at 01:44:54PM -0800, Dave Hansen wrote:
> > On 11/06/2014 01:33 PM, Dave Hansen wrote:
> > > On 11/06/2014 01:27 PM, Aristeu Rozanski wrote:
> > >> +config FLEX_ARRAY
> > >> + bool "Flexible array"
> > >> + default n
> > >> + help
> > >> + This option enables an implementation of flexible arrays which
> > >> + allows creating arrays of fixed size elements with an arbritrary
> > >> + size without requiring the single allocation of a contiguous area.
> > >> +
> > >> + See Documentation/flexible-arrays.txt
> > >
> > > Is there any reason to expose this to the user via Kconfig?
> > >
> > > No sane person would even turn it on if they don't need it.
> >
> > IOW, I think you should just make it:
> >
> > config FLEX_ARRAY
> > def_bool n
>
> Joe Pershes complained on a similar patch on making it default to 'n'.
> Will rework the patches this way.
https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/commit/?h=tiny/unflex-array&id=6631d5fb4cf395ebd2dc0f2da05525b9d3436a3f
Already done.
- Josh Triplett
next prev parent reply other threads:[~2014-11-07 3:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 21:27 [PATCH] lib/flex_array: make build optional Aristeu Rozanski
2014-11-06 21:33 ` Dave Hansen
2014-11-06 21:44 ` Dave Hansen
2014-11-06 21:50 ` Aristeu Rozanski
2014-11-07 3:31 ` Josh Triplett [this message]
2014-11-07 10:18 ` David Rientjes
2014-11-06 21:58 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107033102.GB7249@thin \
--to=josh@joshtriplett.org \
--cc=aris@redhat.com \
--cc=corbet@lwn.net \
--cc=dave@sr71.net \
--cc=eparis@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pshelar@nicira.com \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox