Re: [PATCH 1/8] x86, microcode, intel: forbid some incorrect metadata

Borislav Petkov
2014-10-05T21:13:12Z

On Sun, Oct 05, 2014 at 04:37:03PM -0300, Henrique de Moraes Holschuh wrote:
> Not realy, because it got you confused! :-)

No, it didn't get me confused - it got you confused that I'm confused.

You need to read the comment as a *whole*. The zero value is special
because it is *used* to *denote* a failure. You can use any other
invalid revision value for that matter.

Maybe "denote" was not precise enough - maybe it should say "0 is an
invalid microcode revision and is used to detect the failure of a
microcode update" or similar. Yeah, "detect" sounds better.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--