From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbaKGTDN (ORCPT ); Fri, 7 Nov 2014 14:03:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42787 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbaKGTDM (ORCPT ); Fri, 7 Nov 2014 14:03:12 -0500 Date: Fri, 7 Nov 2014 11:03:11 -0800 From: Greg Kroah-Hartman To: Joe Perches Cc: Steven Rostedt , Al Viro , Petr Mladek , Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value Message-ID: <20141107190311.GA32624@kroah.com> References: <20140929124246.3e39dac8@gandalf.local.home> <2634b19eb1c04a9d31148c1fe6f1f3819be95349.1412031505.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2634b19eb1c04a9d31148c1fe6f1f3819be95349.1412031505.git.joe@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 29, 2014 at 04:08:26PM -0700, Joe Perches wrote: > Adding repeated -1 to the return is not correct. > > Use seq_is_full to test for unnecessary seq_printf uses > and always return 0. > > Signed-off-by: Joe Perches Acked-by: Greg Kroah-Hartman