From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"security@kernel.org" <security@kernel.org>,
James Morris <jmorris@namei.org>
Subject: Re: [GIT PULL] Fix for Integrity subsystem null pointer deref
Date: Sat, 8 Nov 2014 14:25:29 +0300 [thread overview]
Message-ID: <20141108112529.GI6890@mwanda> (raw)
In-Reply-To: <20141029183612.GI6890@mwanda>
On Wed, Oct 29, 2014 at 09:36:12PM +0300, Dan Carpenter wrote:
> I fixed that exact same bug in lustre last week where the xattr size is
> not zero but it's less than the size of the struct. So this seems like
> maybe it could be a common anti-pattern though.
It must not be very common. I wrote a Smatch script which finds both
the lustre and the ima bugs but it doesn't find anything else major.
Apparently parsing vmcores is buggy, for example and I reported a couple
other small bugs to other lists.
fs/proc/vmcore.c:547 update_note_header_size_elf64() warn: is 'notes_section' large enough for 'struct elf64_note'?
fs/proc/vmcore.c:733 update_note_header_size_elf32() warn: is 'notes_section' large enough for 'struct elf32_note'?
regards,
dan carpenter
prev parent reply other threads:[~2014-11-08 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 3:55 [GIT PULL] Fix for Integrity subsystem null pointer deref James Morris
2014-10-29 5:08 ` Andy Lutomirski
2014-10-29 12:59 ` Mimi Zohar
2014-10-29 16:23 ` Andy Lutomirski
2014-10-29 18:29 ` Mimi Zohar
2014-10-29 18:36 ` Dan Carpenter
2014-10-29 18:51 ` Andy Lutomirski
2014-10-29 20:20 ` Mimi Zohar
2014-10-29 21:22 ` Andy Lutomirski
2014-10-29 22:23 ` Dmitry Kasatkin
2014-10-29 22:24 ` Andy Lutomirski
2014-11-08 11:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141108112529.GI6890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox