From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbaKISSj (ORCPT ); Sun, 9 Nov 2014 13:18:39 -0500 Received: from mail-1.atlantis.sk ([80.94.52.57]:58075 "EHLO mail-1.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbaKISSh (ORCPT ); Sun, 9 Nov 2014 13:18:37 -0500 From: Ondrej Zary To: e1000-devel@lists.sourceforge.net Subject: Re: e100: Laptop battery drain and WoL settings from EEPROM Date: Sun, 9 Nov 2014 19:18:03 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: netdev@vger.kernel.org, Kernel development list References: <201411090015.41446.linux@rainbow-software.org> In-Reply-To: <201411090015.41446.linux@rainbow-software.org> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201411091918.04036.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 09 November 2014 00:15:41 Ondrej Zary wrote: > Hello, > there is long-standing problem with battery drain after turning off at > least some Toshiba laptops, see > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/110784 > > I have the same problem with Toshiba Portege R100. When I shut it down in > Linux, the battery is drained to zero in a couple of days. I noticed that > the LAN port is still active, even when AC disconnected. > > The WoL is enabled by default by e100 driver: > > # ethtool eth0 > Settings for eth0: > Supported ports: [ TP MII ] > Supported link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full > Supported pause frame use: No > Supports auto-negotiation: Yes > Advertised link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full > Advertised pause frame use: Symmetric > Advertised auto-negotiation: Yes > Link partner advertised link modes: 10baseT/Half > Link partner advertised pause frame use: No > Link partner advertised auto-negotiation: No > Speed: 10Mb/s > Duplex: Half > Port: MII > PHYAD: 1 > Transceiver: internal > Auto-negotiation: on > Supports Wake-on: g > Wake-on: g > Current message level: 0x00000007 (7) > drv probe link > Link detected: yes > > By this code: > /* Wol magic packet can be enabled from eeprom */ > if ((nic->mac >= mac_82558_D101_A4) && > (nic->eeprom[eeprom_id] & eeprom_id_wol)) { > nic->flags |= wol_magic; > device_set_wakeup_enable(&pdev->dev, true); > } > > because the WoL bit is set in EEPROM ID word: > > # ethtool -e eth0 > Offset Values > ------ ------ > 0x0000: xx xx xx xx xx xx 03 1b 00 00 01 02 01 47 00 00 > 0x0010: 00 00 00 00 a2 49 01 00 79 11 7f 00 00 00 00 00 > ^^ bit 5 here > 0x0020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0040: 00 00 00 00 00 00 3d 10 00 00 00 00 00 00 00 00 > 0x0050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0060: e4 00 3f 40 09 41 00 00 00 00 00 00 00 00 00 00 > 0x0070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f7 fe > > Looks like this laptop is probably WoL-capable even on battery. > > Measured the current from AC adapter: > around 20mA with WoL inactive (shut down from Windows or by power button in > GRUB) around 40mA with WoL active (shut down from Linux) > > So to work-around this problem, users must disable WoL manually on each > boot. > > Maybe the driver should ignore the EEPROM WoL bit on Toshiba susbsystem > IDs? Or completely, like Windows driver does? Suggested patch: diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 781065e..bd4fe64 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -2949,13 +2949,6 @@ static int e100_probe(struct pci_dev *pdev, const struct pci_device_id *ent) } } - /* Wol magic packet can be enabled from eeprom */ - if ((nic->mac >= mac_82558_D101_A4) && - (nic->eeprom[eeprom_id] & eeprom_id_wol)) { - nic->flags |= wol_magic; - device_set_wakeup_enable(&pdev->dev, true); - } - /* ack any pending wake events, disable PME */ pci_pme_active(pdev, false); -- Ondrej Zary