Re: [PATCH] ALSA: korg1212: cleanup of printk

Takashi Iwai
2014-11-10T10:06:06Z

At Mon, 10 Nov 2014 12:50:26 +0530,
Sudip Mukherjee wrote:
>
> hi Takashi,
> I have a doubt regarding this korg1212.
> snd_korg1212_free_pcm is just making korg1212->pcm as NULL. But are we not supposed to release the allocated memory ?
> in snd_pcm_new we are allocating memory.

The allocated memories by snd_pcm_new() are freed automatically.
The private_free callback is for extra memory that is allocated in the
outside. But in this case, it's the chip object that will be freed
snd_korg1212_dev_free(), so snd_korg1212_free_pcm() doesn't do
anything. (Actually it can be dropped.)

Takashi