From: NeilBrown <neilb@suse.de>
To: "Евгений Поляков" <zbr@ioremap.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
GTA04 owners <gta04-owner@goldelico.com>
Subject: Re: [PATCH] w1: support auto-load of w1_bq27000 module.
Date: Mon, 10 Nov 2014 11:32:21 +1100 [thread overview]
Message-ID: <20141110113221.17cb1535@notabene.brown> (raw)
In-Reply-To: <18301415578289@web5g.yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
On Mon, 10 Nov 2014 03:11:29 +0300 Евгений Поляков <zbr@ioremap.net> wrote:
> Hi
>
> 08.11.2014, 02:33, "NeilBrown" <neilb@suse.de>:
> > 1/ change request_module call to zero-pad single digit
> > family numbers. This appears to be the intention of
> > the code, but not what it actually does.
> >
> > This means that the alias created for W1_FAMILY_SMEM_01
> > might actually be useful.
> >
> > 2/ Define a family name for the BQ27000 battery charge monitor.
> > Unfortunately this is the same number as W1_FAMILY_SMEM_01
> > so if both a compiled on a system, one module might need to
> > be blacklisted.
> >
> > 3/ Add a MODULE_ALIAS for the bq27000.
> >
> > Signed-off-by: NeilBrown <neilb@suse.de>
>
> Looks good to me.
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>
> Which tree should this patch use to get into the kernel?
MAINTAINERS lists you as the maintainer, so I though you would know.
When is doubt: send to akpm .. or gregkh.
It looks like greg has more Signed-off-by's in drivers/w1 than akpm,
so I'll add your acked-by and send to him.
Thanks,
NeilBrown
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-11-10 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 23:32 [PATCH] w1: support auto-load of w1_bq27000 module NeilBrown
2014-11-10 0:11 ` Евгений Поляков
2014-11-10 0:32 ` NeilBrown [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-19 3:04 NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110113221.17cb1535@notabene.brown \
--to=neilb@suse.de \
--cc=gta04-owner@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox