From: Jean-Francois Moine <moinejf@free.fr>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers
Date: Mon, 10 Nov 2014 20:12:54 +0100 [thread overview]
Message-ID: <20141110201254.65674552@armhf> (raw)
In-Reply-To: <20141110190332.GG3815@sirena.org.uk>
On Mon, 10 Nov 2014 19:03:32 +0000
Mark Brown <broonie@kernel.org> wrote:
> On Sun, Nov 09, 2014 at 08:33:45PM +0100, Jean-Francois Moine wrote:
> > From Russell King:
> > of_node_put() modifies the struct device_node contents. Therefore,
> > of_node_put() definitely not treating the data pointed to as read-only,
> > and therefore it is completely inappropriate for it to be marked "const".
>
> Did Russell write this patch (in which case it's missing a signoff and
> his e-mail address above) or are you trying to say "Russell King
> said..."?
Sorry, that was "Russell said ...".
Do you want I resubmit the patch?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2014-11-10 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 19:40 [PATCH v2 0/2] Fix some 'const' problems Jean-Francois Moine
2014-11-09 11:38 ` [PATCH v2 2/2] ASoC: simple-card: Remove useless casts Jean-Francois Moine
2014-11-10 19:02 ` Mark Brown
2014-11-09 19:33 ` [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers Jean-Francois Moine
2014-11-10 19:03 ` Mark Brown
2014-11-10 19:12 ` Jean-Francois Moine [this message]
2014-11-10 19:25 ` Mark Brown
2014-11-10 19:37 ` Mark Brown
2014-11-10 19:51 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110201254.65674552@armhf \
--to=moinejf@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox