From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752035AbaKJXu0 (ORCPT ); Mon, 10 Nov 2014 18:50:26 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:65110 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751507AbaKJXuY (ORCPT ); Mon, 10 Nov 2014 18:50:24 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/d+HD5UdO1S/Jd8uKaU4hb Date: Mon, 10 Nov 2014 15:49:38 -0800 From: Tony Lindgren To: Nishanth Menon Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, "Franklin Cooper Jr." Subject: Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports Message-ID: <20141110234937.GG31454@atomide.com> References: <1413908295-699-1-git-send-email-nm@ti.com> <3461773.MMIsJQMVIu@wuerfel> <5446BCEB.3020708@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5446BCEB.3020708@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nishanth Menon [141021 13:08]: > On 10/21/2014 02:57 PM, Arnd Bergmann wrote: > > On Tuesday 21 October 2014 11:18:15 Nishanth Menon wrote: > >> Add serial port aliases for consoles > 6. > >> > >> Signed-off-by: Nishanth Menon > >> --- > >> arch/arm/boot/dts/dra7.dtsi | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > >> index 9cc9843..208dd83 100644 > >> --- a/arch/arm/boot/dts/dra7.dtsi > >> +++ b/arch/arm/boot/dts/dra7.dtsi > >> @@ -34,6 +34,10 @@ > >> serial3 = &uart4; > >> serial4 = &uart5; > >> serial5 = &uart6; > >> + serial6 = &uart7; > >> + serial7 = &uart8; > >> + serial8 = &uart9; > >> + serial9 = &uart10; > >> > > > > I think this was wrong to start with: The aliases should be in the per-board > > .dts file and only list the ones that are actually connected to the outside. > > > > Otherwise the numbering won't match what's written on the board. > > At least in the case of DRA7 boards, they are not written specifically > since they come out over onboard FTDI usb2serial. > > This will at least ensure that /dev/ttyO9 will always point to uart10 > no matter the board, instead of having ttyO0 always pointing to > console serial port no matter the board (and having to guess which > figure out it actually was aliased to). It seems that having the UART numbering make sense is a good reason to apply this one. So applying into omap-for-v3.19/dt. Regards, Tony