From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Eric Paris <eparis@parisplace.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ftruncate, truncate: create fanotify events
Date: Mon, 10 Nov 2014 23:34:15 -0800 [thread overview]
Message-ID: <20141111073415.GA21776@infradead.org> (raw)
In-Reply-To: <20141110203029.GA8125@quack.suse.cz>
On Mon, Nov 10, 2014 at 09:30:29PM +0100, Jan Kara wrote:
> So what I somewhat dislike about this patch is that notify_change() is
> sometimes called with dentry and sometimes with path. That way it's not
> completely clear when fanotify events will be generated and when not.
> Sadly it isn't easy to provide struct path in all the places where we are
> calling notify_change() so I'm not sure what would a better solution look
> like either :(
I suspect the right thing to do is to split out the truncate path
from notify_change, as it's fairly different anyway.
next prev parent reply other threads:[~2014-11-11 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 18:16 [PATCH 1/1] ftruncate: create FAN_MODIFY and IN_MODIFY events Heinrich Schuchardt
2014-10-06 13:24 ` Jan Kara
2014-10-06 20:09 ` Heinrich Schuchardt
2014-10-07 19:23 ` Jan Kara
2014-10-23 21:35 ` [PATCH v2 1/1] ftruncate, truncate: create fanotify events Heinrich Schuchardt
2014-11-10 20:30 ` Jan Kara
2014-11-10 23:10 ` Heinrich Schuchardt
2014-11-11 7:34 ` Christoph Hellwig [this message]
2014-11-11 11:09 ` Jan Kara
2014-11-11 19:55 ` Heinrich Schuchardt
2014-11-14 10:01 ` Jan Kara
2014-11-14 21:30 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111073415.GA21776@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=eparis@parisplace.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox