From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879AbaKKTRy (ORCPT ); Tue, 11 Nov 2014 14:17:54 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:56909 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbaKKTRv (ORCPT ); Tue, 11 Nov 2014 14:17:51 -0500 Date: Tue, 11 Nov 2014 11:17:45 -0800 From: Guenter Roeck To: Pavel Machek Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alan Cox , Alexander Graf , Andrew Morton , Geert Uytterhoeven , Heiko Stuebner , Lee Jones , Len Brown , Linus Torvalds , "Rafael J. Wysocki" , Romain Perier Subject: Re: [PATCH v6 00/48] kernel: Add support for power-off handler call chain Message-ID: <20141111191745.GA24918@roeck-us.net> References: <1415583785-6980-1-git-send-email-linux@roeck-us.net> <20141110083347.GA29543@amd> <20141111182023.GA21970@roeck-us.net> <20141111185019.GA29452@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141111185019.GA29452@amd> User-Agent: Mutt/1.5.21 (2010-09-15) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020208.546260DE.02E2,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 11, 2014 at 07:50:20PM +0100, Pavel Machek wrote: > On Tue 2014-11-11 10:20:23, Guenter Roeck wrote: > > On Mon, Nov 10, 2014 at 09:33:48AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > Introduce a system power-off handler call chain to solve the described > > > > problems. This call chain is expected to be executed from the architecture > > > > specific machine_power_off() function. Drivers providing system power-off > > > > functionality are expected to register with this call chain. By using the > > > > priority field in the notifier block, callers can control power-off > > > > handler > > > > > > Linus rather disliked the idea of notifier chains for this... And I > > > don't see how it got addressed. > > > > > Hi all, > > > > After more thought, I concluded that it is technically impossible to support > > multiple power-off handlers without some kind of list or call chain, no matter > > how it is called. Given the opposition from Linus and the power maintainers > > to the series, I decided to shelf it. > > Well, you can still do preparations -- current code directly setting > pm_power_off is ugly -- so that if you want to switch to call chain > later, it will be easy. > Yes, it is ugly, but with pretty much everyone who counts opposed to my proposal for a cleanup I don't really have an idea how to continue. In addition to that, I did this as a community project in my free time, I don't need it myself, I already spent way more time on it than I thought it would take, there is no end in sight, and other things I am working on are significantly more important for me. At some point one has to cut one's losses. Guenter