From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbaKLI7V (ORCPT ); Wed, 12 Nov 2014 03:59:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbaKLI7T (ORCPT ); Wed, 12 Nov 2014 03:59:19 -0500 Date: Wed, 12 Nov 2014 09:58:59 +0100 From: Jiri Olsa To: kan.liang@intel.com Cc: acme@kernel.org, a.p.zijlstra@chello.nl, eranian@google.com, linux-kernel@vger.kernel.org, mingo@redhat.com, paulus@samba.org, ak@linux.intel.com Subject: Re: [PATCH 2/2] perf tools: Construct LBR call chain Message-ID: <20141112085859.GB25338@krava> References: <1415285886-16949-1-git-send-email-kan.liang@intel.com> <1415285886-16949-3-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415285886-16949-3-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 06, 2014 at 09:58:06AM -0500, kan.liang@intel.com wrote: SNIP > + callchain_nr = i + 1; > + } > + } > + > + printf("... chain: nr:%" PRIu64 "\n", total_nr); > + > + for (i = 0; i < callchain_nr + 1; i++) > printf("..... %2d: %016" PRIx64 "\n", > i, sample->callchain->ips[i]); > + > + if (total_nr > callchain_nr) { > + struct branch_stack *lbr_stack = sample->branch_stack; > + > + for (i = 0; i < lbr_stack->nr; i++) > + printf("..... %2d: %016" PRIx64 "\n", > + (int)(i + callchain_nr + 1), lbr_stack->entries[i].from); could u describe in comment why only ->from entries are interesting? thanks, jirka