From: Thierry Reding <treding@nvidia.com>
To: bpqw <bpqw@micron.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jason Cooper <jason@lakedaemon.net>,
"Mark Brown" <broonie@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"Florian Vaussard" <florian.vaussard@epfl.ch>,
Andrew Lunn <andrew@lunn.ch>, Silvio F <silvio.fricke@gmail.com>,
Hayato Suzuki <hytszk@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.
Date: Wed, 12 Nov 2014 10:02:17 +0100 [thread overview]
Message-ID: <20141112090215.GA29664@ulmo.nvidia.com> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6315EB0ED@NTXXIAMBX02.xacn.micron.com>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Wed, Nov 12, 2014 at 01:26:58AM +0000, bpqw wrote:
> >Signed-off-by: bean huo <beanhuo@micron.com>
> >Signed-off-by: bpqw <bpqw@micron.com>
> >---
> >V2:
> > - Add signed-off-by
> > - Modify commit logs that wrapped to less than 80 columns
>
> Dear maintainers:
>
> Please give some tips,if this patch is OK?thanks!
Patch looks okay to me content-wise, but you might want to use proper
names and capitalization for the From: and Signed-off-by: lines. bpqw
doesn't look like a real name to me, and "bean huo" should probably
be "Bean Huo".
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-12 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 1:26 [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd bpqw
2014-11-12 9:02 ` Thierry Reding [this message]
2014-11-12 14:16 ` bpqw
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 13:17 bpqw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112090215.GA29664@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=andrew@lunn.ch \
--cc=bpqw@micron.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=hytszk@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=silvio.fricke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox