public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Allen Martin <amartin@nvidia.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Ensure voltages are within the allowed range
Date: Wed, 12 Nov 2014 11:45:05 +0000	[thread overview]
Message-ID: <20141112114505.GE3815@sirena.org.uk> (raw)
In-Reply-To: <1415787125-31218-1-git-send-email-thierry.reding@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Wed, Nov 12, 2014 at 11:12:05AM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Unless a regulator has a fixed output voltage the core will not attempt
> to modify the output voltage. This can cause a situation where a driver
> enables the regulator but the currently configured voltage is outside
> the valid range.
> 
> Fix this by constraining the current voltage to the allowed range upon
> regulator registration.

I've thought about doing this before but it's tricky as if there is a
voltage range it's possible something needs it at the high rather than
low end of the range and will get upset if the voltage gets lowered.
Setting the top voltage also has risks (though less bad when constraints
are sane) and requires working out what that is which we'd need to write
the machinery to do.

This is all especially likely to break given the depressing desire
everyone seems to have to put the maximum possible voltage range for
their regulators in constraints regardless of what's actually sensible
for their board design.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-11-12 11:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 10:12 [PATCH] regulator: Ensure voltages are within the allowed range Thierry Reding
2014-11-12 11:45 ` Mark Brown [this message]
2014-11-12 12:02   ` Thierry Reding
2014-11-12 14:48     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141112114505.GE3815@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=amartin@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox