From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Christoph Lameter <cl@linux.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>, Tejun Heo <tj@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Mike Frysinger <vapier@gentoo.org>,
Minchan Kim <minchan.kim@gmail.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Max Krasnyansky <maxk@qti.qualcomm.com>,
Hugh Dickins <hughd@google.com>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@kernel.org>, Kevin Hilman <khilman@linaro.org>
Subject: Re: Future of NOHZ full/isolation development (was Re: [NOHZ] Remove scheduler_tick_max_deferment)
Date: Wed, 12 Nov 2014 16:06:51 +0100 [thread overview]
Message-ID: <20141112150651.GF21343@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKohpo=U7K==YMytwcGwteTXdf1RFdxo8BoDhfR-9AriL83D8Q@mail.gmail.com>
On Wed, Nov 12, 2014 at 08:26:05PM +0530, Viresh Kumar wrote:
> On 12 November 2014 19:24, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > I'd rather leave that to tracepoints. Like trace_hrtimer_spurious().
>
> Yeah, it was just to prove things right on the console without getting
> into traces.
>
> > Or better yet: have trace_hrtimer_interrupt() which we can compare against
> > trace_hrtimer_expire_entry/exit() to check if any hrtimer callback have run
> > in the interrupt. This way we avoid workarounds like the above count.
>
> Yeah, I also believe we better add this debug information to mainline kernel.
> I will try to get a patch for that soon.
>
> Would it be recommended to add both trace points?
> i.e. trace_hrtimer_interrupt() and trace_hrtimer_spurious()
I don't think you need to add anything. We already have tracepoints for
every single interrupt (and therefore also for the hrtimer one) and we
have expiry tracepoints.
next prev parent reply other threads:[~2014-11-12 15:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 16:01 [NOHZ] Remove scheduler_tick_max_deferment Christoph Lameter
2014-11-01 19:18 ` Thomas Gleixner
2014-11-01 21:52 ` Christoph Lameter
2014-11-01 22:33 ` Thomas Gleixner
2014-11-06 17:24 ` Christoph Lameter
2014-11-10 7:11 ` Viresh Kumar
2014-11-10 15:31 ` Paul E. McKenney
2014-11-10 16:21 ` Christoph Lameter
2014-11-10 18:26 ` Christoph Lameter
2014-11-11 17:15 ` Future of NOHZ full/isolation development (was Re: [NOHZ] Remove scheduler_tick_max_deferment) Frederic Weisbecker
2014-11-11 17:39 ` Paul E. McKenney
2014-11-11 18:00 ` Christoph Lameter
2014-11-12 6:11 ` Viresh Kumar
2014-11-12 13:54 ` Frederic Weisbecker
2014-11-12 14:56 ` Viresh Kumar
2014-11-12 15:06 ` Peter Zijlstra [this message]
2014-11-12 15:16 ` Viresh Kumar
2014-11-13 7:22 ` Viresh Kumar
2014-11-10 16:19 ` [NOHZ] Remove scheduler_tick_max_deferment Christoph Lameter
2014-11-10 22:43 ` Frederic Weisbecker
2014-11-11 14:58 ` Christoph Lameter
2014-11-11 15:36 ` Frederic Weisbecker
2014-11-11 17:08 ` Christoph Lameter
2014-11-10 20:26 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112150651.GF21343@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=john.stultz@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qti.qualcomm.com \
--cc=minchan.kim@gmail.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vapier@gentoo.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox