From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbaKLQpx (ORCPT ); Wed, 12 Nov 2014 11:45:53 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:41696 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbaKLQpw (ORCPT ); Wed, 12 Nov 2014 11:45:52 -0500 Date: Wed, 12 Nov 2014 17:45:41 +0100 From: Peter Zijlstra To: Stanislaw Gruszka Cc: linux-kernel@vger.kernel.org, Rik van Riel , Frederic Weisbecker , KOSAKI Motohiro , Oleg Nesterov , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH v2] sched/cputime: fix clock_nanosleep/clock_gettime inconsistency Message-ID: <20141112164541.GN29390@twins.programming.kicks-ass.net> References: <1415788168-3165-1-git-send-email-sgruszka@redhat.com> <20141112111553.GA21343@twins.programming.kicks-ass.net> <20141112122155.GA3250@redhat.com> <20141112125158.GB21343@twins.programming.kicks-ass.net> <20141112155843.GA24803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141112155843.GA24803@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 12, 2014 at 04:58:44PM +0100, Stanislaw Gruszka wrote: > +static void update_curr_fair(struct rq *rq) > +{ > + update_curr(&rq->cfs); + update_curr(cfs_rq_of(&rq->curr.se)); > +} I did the above change. While looking it over I realized we'd not actually update the task when cgroups are in use.