From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org,
H Peter Anvin <h.peter.anvin@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, x86@kernel.org
Subject: Re: [PATCH 6/6] x86: Use clwb in drm_clflush_virt_range
Date: Thu, 13 Nov 2014 12:20:17 +0100 [thread overview]
Message-ID: <20141113112017.GA14416@pd.tnic> (raw)
In-Reply-To: <5464220D.6090204@amacapital.net>
On Wed, Nov 12, 2014 at 07:14:21PM -0800, Andy Lutomirski wrote:
> On 11/11/2014 10:43 AM, Ross Zwisler wrote:
> > If clwb is available on the system, use it in drm_clflush_virt_range.
> > If clwb is not available, fall back to clflushopt if you can.
> > If clflushopt is not supported, fall all the way back to clflush.
>
> I don't know exactly what drm_clflush_virt_range (and the other
> functions you're modifying similarly) are for, but it seems plausible to
> me that they're used before reads to make sure that non-coherent memory
> sees updated data. If that's true, then this will break it.
Why would it break it? The updated cachelines will be in memory and
subsequent reads will be serviced from the cache instead from going to
memory as it is not invalidated as it would be by CLFLUSH.
/me is puzzled.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-11-13 11:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:43 [PATCH 0/6] add support for new persistent memory instructions Ross Zwisler
2014-11-11 18:43 ` [PATCH 1/6] x86: Add support for the pcommit instruction Ross Zwisler
2014-11-13 3:25 ` Andy Lutomirski
2014-11-14 21:07 ` Ross Zwisler
2014-11-14 21:09 ` Andy Lutomirski
2014-11-11 18:43 ` [PATCH 2/6] x86/alternative: Add alternative_io_2 Ross Zwisler
2014-11-11 18:43 ` [PATCH 3/6] x86: Add support for the clwb instruction Ross Zwisler
2014-11-11 19:12 ` Borislav Petkov
2014-11-11 19:19 ` Borislav Petkov
2014-11-11 19:40 ` Ross Zwisler
2014-11-11 19:46 ` Borislav Petkov
2014-11-11 19:54 ` Ross Zwisler
2014-11-11 19:48 ` Ross Zwisler
2014-11-11 19:54 ` Borislav Petkov
2014-11-12 12:39 ` Borislav Petkov
2014-11-12 13:38 ` Anvin, H Peter
2014-11-12 14:12 ` Borislav Petkov
2014-11-13 17:47 ` Ross Zwisler
2014-11-11 18:43 ` [PATCH 4/6] x86: Use clwb in clflush_cache_range Ross Zwisler
2014-11-11 18:43 ` [PATCH 5/6] x86: Use clwb in drm_clflush_page Ross Zwisler
2014-11-11 18:43 ` [PATCH 6/6] x86: Use clwb in drm_clflush_virt_range Ross Zwisler
2014-11-13 3:14 ` Andy Lutomirski
2014-11-13 11:20 ` Borislav Petkov [this message]
2014-11-13 16:38 ` Andy Lutomirski
2014-11-13 17:11 ` Borislav Petkov
2014-11-13 17:33 ` Ville Syrjälä
2014-11-13 17:47 ` Borislav Petkov
2014-11-13 18:14 ` Ville Syrjälä
2014-11-13 18:43 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113112017.GA14416@pd.tnic \
--to=bp@alien8.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=h.peter.anvin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox