From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: ice1712: remove unused variable
Date: Fri, 14 Nov 2014 13:49:07 +0530 [thread overview]
Message-ID: <20141114081907.GA6796@sudip-PC> (raw)
In-Reply-To: <s5h1tp7jfay.wl-tiwai@suse.de>
On Thu, Nov 13, 2014 at 04:22:45PM +0100, Takashi Iwai wrote:
> At Thu, 13 Nov 2014 20:44:17 +0530,
> Sudip Mukherjee wrote:
> >
<snip>
> > if (snd_pcm_format_width(runtime->format) == 16)
> > tmp &= ~0x04;
> > diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c
> > index 1112ec1..1f40dab 100644
> > --- a/sound/pci/ice1712/revo.c
> > +++ b/sound/pci/ice1712/revo.c
> > @@ -481,7 +481,6 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice)
> > static const unsigned char ak4114_init_txcsb[] = {
> > 0x41, 0x02, 0x2c, 0x00, 0x00
> > };
> > - int err;
> >
> > struct revo51_spec *spec;
> > spec = kzalloc(sizeof(*spec), GFP_KERNEL);
> > @@ -489,11 +488,9 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice)
> > return -ENOMEM;
> > ice->spec = spec;
> >
> > - err = snd_ak4114_create(ice->card,
> > - ap192_ak4114_read,
> > - ap192_ak4114_write,
> > - ak4114_init_vals, ak4114_init_txcsb,
> > - ice, &spec->ak4114);
> > + snd_ak4114_create(ice->card, ap192_ak4114_read, ap192_ak4114_write,
> > + ak4114_init_vals, ak4114_init_txcsb, ice,
> > + &spec->ak4114);
>
> IMO, this is rather a bug. It should return the error (with a proper
> error handling).
>
error handling is already there. ap192_ak4114_init is being called by revo_init,
where the return value is being checked. revo_init is the callback function of
chip_init, so if we return the error value here then chip_init will fail.
but since the author commented "error ignored; it's no fatal error", so i also
thought of ignoring the error.
I will send you a revised patch.
thanks
sudip
>
> thanks,
>
> Takashi
>
>
> > /* AK4114 in Revo cannot detect external rate correctly.
> > * No reason to stop capture stream due to incorrect checks */
> > spec->ak4114->check_flags = AK4114_CHECK_NO_RATE;
> > --
> > 1.8.1.2
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
next prev parent reply other threads:[~2014-11-14 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 15:14 [PATCH 1/2] ALSA: ice1712: remove unneeded return statement Sudip Mukherjee
2014-11-13 15:14 ` [PATCH 2/2] ALSA: ice1712: remove unused variable Sudip Mukherjee
2014-11-13 15:22 ` [alsa-devel] " Takashi Iwai
2014-11-14 8:19 ` Sudip Mukherjee [this message]
2014-11-13 15:21 ` [PATCH 1/2] ALSA: ice1712: remove unneeded return statement Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114081907.GA6796@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox