Re: [PATCH v7 08/13] usb: chipidea: add a usb2 driver for ci13xxx

Antoine Tenart
2014-11-17T10:12:22Z

Felipe,

On Fri, Nov 14, 2014 at 03:13:34PM -0600, Felipe Balbi wrote:
> On Fri, Nov 14, 2014 at 10:10:52PM +0100, Antoine Tenart wrote:
> > On Fri, Nov 14, 2014 at 03:08:32PM -0600, Felipe Balbi wrote:
> > > On Fri, Nov 14, 2014 at 04:25:58PM +0100, Antoine Tenart wrote:
> > > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock
> > > > and DMA mask, to support USB2 ChipIdea controllers that don't need
> > > > specific functions.
> > > >
> > > > Tested on the Marvell Berlin SoCs USB controllers.
> > > >
> > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > > > ---
> > > > drivers/usb/chipidea/Makefile | 1 +
> > > > drivers/usb/chipidea/ci_hdrc_usb2.c | 117 ++++++++++++++++++++++++++++++++++++
> > > > 2 files changed, 118 insertions(+)
> > > > create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c
> > > >
> > > > diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
> > > > index 2f099c7df7b5..1fc86a2ca22d 100644
> > > > --- a/drivers/usb/chipidea/Makefile
> > > > +++ b/drivers/usb/chipidea/Makefile
> > > > @@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM) += otg_fsm.o
> > > >
> > > > # Glue/Bridge layers go here
> > > >
> > > > +obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_usb2.o
> > >
> > > usb2 is too generic, you should call it ci_hdcr_marvell, or something
> > > like that.
> >
> > This driver is generic, and not only for Marvell Berlin SoCs. It is part
> > of the Berlin USB series as it is the first SoC to use it but Xilinx can
> > also use it for example.
>
> then how about ci_hdrc_generic.c ?

We had this discussion during in the v2 thread of this series[1]. I tend
to prefer not using the 'generic' keyword. I think using 'usb2' is
generic enough here.

Antoine

[1] https://lkml.org/lkml/2014/6/24/197

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering