* [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map
@ 2014-11-14 21:32 Dmitry Torokhov
2014-11-14 23:53 ` James Hogan
2014-11-27 13:35 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2014-11-14 21:32 UTC (permalink / raw)
To: Linus Walleij
Cc: Alexandre Courbot, Wolfram Sang, James Hogan, linux-gpio,
linux-kernel
irq_of_parse_and_map() returns 0 on error, so testing for negative
result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
Not tested, found by casual inspection of the code.
drivers/gpio/gpio-tz1090.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
index 9e90177..e3024bb 100644
--- a/drivers/gpio/gpio-tz1090.c
+++ b/drivers/gpio/gpio-tz1090.c
@@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
bank->irq = irq_of_parse_and_map(np, 0);
/* The interrupt is optional (it may be used by another core on chip) */
- if (bank->irq < 0) {
+ if (!bank->irq) {
dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
info->index);
return 0;
--
2.1.0.rc2.206.gedb03e5
--
Dmitry
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map
2014-11-14 21:32 [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Dmitry Torokhov
@ 2014-11-14 23:53 ` James Hogan
2014-11-15 0:44 ` Dmitry Torokhov
2014-11-27 13:35 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: James Hogan @ 2014-11-14 23:53 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Linus Walleij, Alexandre Courbot, Wolfram Sang, linux-gpio,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote:
> irq_of_parse_and_map() returns 0 on error, so testing for negative
> result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Good catch, thanks!
Acked-by: James Hogan <james.hogan@imgtec.com>
A quick coccinelle script shows up numerous other cases of this error
around the kernel tree too...
Cheers
James
> ---
>
> Not tested, found by casual inspection of the code.
>
> drivers/gpio/gpio-tz1090.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
> index 9e90177..e3024bb 100644
> --- a/drivers/gpio/gpio-tz1090.c
> +++ b/drivers/gpio/gpio-tz1090.c
> @@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
> bank->irq = irq_of_parse_and_map(np, 0);
>
> /* The interrupt is optional (it may be used by another core on chip) */
> - if (bank->irq < 0) {
> + if (!bank->irq) {
> dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
> info->index);
> return 0;
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map
2014-11-14 23:53 ` James Hogan
@ 2014-11-15 0:44 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2014-11-15 0:44 UTC (permalink / raw)
To: James Hogan
Cc: Linus Walleij, Alexandre Courbot, Wolfram Sang, linux-gpio,
linux-kernel
On Friday, November 14, 2014 11:53:07 PM James Hogan wrote:
> On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote:
> > irq_of_parse_and_map() returns 0 on error, so testing for negative
> > result never works.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
>
> Good catch, thanks!
>
> Acked-by: James Hogan <james.hogan@imgtec.com>
>
> A quick coccinelle script shows up numerous other cases of this error
> around the kernel tree too...
Yeah, I sent out a few patches today.
Thanks,
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map
2014-11-14 21:32 [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-14 23:53 ` James Hogan
@ 2014-11-27 13:35 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-11-27 13:35 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Alexandre Courbot, Wolfram Sang, James Hogan,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Fri, Nov 14, 2014 at 10:32 PM, Dmitry Torokhov <dtor@chromium.org> wrote:
> irq_of_parse_and_map() returns 0 on error, so testing for negative
> result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Patch applied with James' ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-27 13:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 21:32 [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-14 23:53 ` James Hogan
2014-11-15 0:44 ` Dmitry Torokhov
2014-11-27 13:35 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox