* [PATCH] irqchip: brcmstb-l2: fix error handling of irq_of_parse_and_map
@ 2014-11-14 22:16 Dmitry Torokhov
2014-11-15 19:41 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2014-11-14 22:16 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Jason Cooper, Florian Fainelli, Arnd Bergmann, Kevin Cernekee,
Brian Norris, linux-kernel
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
Not tested, found by casual code inspection.
drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
index 4aa653a..313c2c6 100644
--- a/drivers/irqchip/irq-brcmstb-l2.c
+++ b/drivers/irqchip/irq-brcmstb-l2.c
@@ -139,9 +139,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np,
writel(0xffffffff, data->base + CPU_CLEAR);
data->parent_irq = irq_of_parse_and_map(np, 0);
- if (data->parent_irq < 0) {
+ if (!data->parent_irq) {
pr_err("failed to find parent interrupt\n");
- ret = data->parent_irq;
+ ret = -EINVAL;
goto out_unmap;
}
--
2.1.0.rc2.206.gedb03e5
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip: brcmstb-l2: fix error handling of irq_of_parse_and_map
2014-11-14 22:16 [PATCH] irqchip: brcmstb-l2: fix error handling of irq_of_parse_and_map Dmitry Torokhov
@ 2014-11-15 19:41 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2014-11-15 19:41 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Thomas Gleixner, Jason Cooper, Arnd Bergmann, Kevin Cernekee,
Brian Norris, linux-kernel@vger.kernel.org
2014-11-14 14:16 GMT-08:00 Dmitry Torokhov <dtor@chromium.org>:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
> index 4aa653a..313c2c6 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -139,9 +139,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np,
> writel(0xffffffff, data->base + CPU_CLEAR);
>
> data->parent_irq = irq_of_parse_and_map(np, 0);
> - if (data->parent_irq < 0) {
> + if (!data->parent_irq) {
> pr_err("failed to find parent interrupt\n");
> - ret = data->parent_irq;
> + ret = -EINVAL;
> goto out_unmap;
> }
>
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-15 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 22:16 [PATCH] irqchip: brcmstb-l2: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-15 19:41 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox