From: James Hogan <james.hogan@imgtec.com>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map
Date: Fri, 14 Nov 2014 23:53:07 +0000 [thread overview]
Message-ID: <20141114235307.GF1739@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20141114213256.GA24709@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote:
> irq_of_parse_and_map() returns 0 on error, so testing for negative
> result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Good catch, thanks!
Acked-by: James Hogan <james.hogan@imgtec.com>
A quick coccinelle script shows up numerous other cases of this error
around the kernel tree too...
Cheers
James
> ---
>
> Not tested, found by casual inspection of the code.
>
> drivers/gpio/gpio-tz1090.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
> index 9e90177..e3024bb 100644
> --- a/drivers/gpio/gpio-tz1090.c
> +++ b/drivers/gpio/gpio-tz1090.c
> @@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
> bank->irq = irq_of_parse_and_map(np, 0);
>
> /* The interrupt is optional (it may be used by another core on chip) */
> - if (bank->irq < 0) {
> + if (!bank->irq) {
> dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
> info->index);
> return 0;
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-14 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 21:32 [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-14 23:53 ` James Hogan [this message]
2014-11-15 0:44 ` Dmitry Torokhov
2014-11-27 13:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114235307.GF1739@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=dtor@chromium.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox