From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Martyn Welch <martyn.welch@ge.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Manohar Vanga <manohar.vanga@gmail.com>,
Igor Alekseev <igor.alekseev@itep.ru>
Subject: Re: [PATCH 2/3] staging: vme: mmap() support for vme_user
Date: Sat, 15 Nov 2014 10:51:33 +0300 [thread overview]
Message-ID: <20141115075133.GP6749@mwanda> (raw)
In-Reply-To: <1416008178-9393-3-git-send-email-dmitry.kalinkin@gmail.com>
On Sat, Nov 15, 2014 at 02:36:17AM +0300, Dmitry Kalinkin wrote:
> +int vme_master_mmap(struct vme_resource *resource, struct vm_area_struct *vma)
> +{
> + struct vme_master_resource *image;
> + phys_addr_t phys_addr;
> + unsigned long vma_size;
> +
> + if (resource->type != VME_MASTER) {
> + printk(KERN_ERR "Not a master resource\n");
Run your patch through scripts/checkpatch.pl
Also warning messages let people flood /var/log/messages so they can be
a DoS vector.
regards,
dan carpenter
next prev parent reply other threads:[~2014-11-15 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 23:36 [PATCH 0/3] mmap() for vme_user and CR/CSR fix for master Dmitry Kalinkin
2014-11-14 23:36 ` [PATCH 1/3] staging: vme: use image mutex for ioctl() Dmitry Kalinkin
2014-11-14 23:36 ` [PATCH 2/3] staging: vme: mmap() support for vme_user Dmitry Kalinkin
2014-11-15 7:51 ` Dan Carpenter [this message]
2015-02-26 15:53 ` [PATCHv2 0/3] mmap() for vme_user and CR/CSR fix for master Dmitry Kalinkin
2015-02-26 15:53 ` [PATCHv2 1/3] staging: vme: use image mutex for ioctl() Dmitry Kalinkin
2015-02-26 15:53 ` [PATCHv2 2/3] staging: vme: mmap() support for vme_user Dmitry Kalinkin
2015-02-26 15:53 ` [PATCHv2 3/3] vme: tsi148: Master windows support USERx and CR/CSR accesses, not slaves Dmitry Kalinkin
2014-11-14 23:36 ` [PATCH " Dmitry Kalinkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141115075133.GP6749@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.kalinkin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=igor.alekseev@itep.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox