Re: [PATCH] staging: media: bcm2048: fix coding style error

From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christian Resell <christian.resell@gmail.com>,
	m.chehab@samsung.com, devel@driverdev.osuosl.org,
	askb23@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
	hans.verkuil@cisco.com, pali.rohar@gmail.com,
	fengguang.wu@intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix coding style error
Date: Sat, 15 Nov 2014 22:32:28 +0100	[thread overview]
Message-ID: <20141115213228.GD8088@t400> (raw)
In-Reply-To: <20141115205934.GB21240@amd>

On 11/15, Pavel Machek wrote:
> On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > On 11/15, Christian Resell wrote:
> > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > For the eudyptula challenge (http://eudyptula-challenge.org/).
> > 
> > Nice, however we do not need the information about the 'eudyptula
> > challenge' in the commit message.
> > 
> > If you want to include extra information please do it after the '---'
> > line (just below the signed-off). You will find more details in the
> > SubmittingPatches (chapter 15) of the kernel documentation.
> 
> Greg is staging tree maintainer... And if single extra space is all
> you can fix in the driver, perhaps it is not worth the patch?

I think that every contribution, as long as it acctually fixes
something, is worth the patch. The beauty of the open source community
is that we do when we have time as much as we are able to do - totally
no stress.

You, Pavel, are more experienced however those who are not have to learn
somehow and one of the options is to start with something very simple.
Sometimes the 'simple' means oneliner however as long as it compiles, is
inline with the coding standard and in general is an improvement then it
is good.

Regards,
Konrad

> 									Pavel
> 
> > Thanks,
> > Konrad
> >  
> > > Signed-off-by: Christian F. Resell <christian.resell@gmail.com>
> > > ---
> > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > index 2bba370..bdc6854 100644
> > > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > @@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
> > >   *	bcm2048_i2c_driver - i2c driver interface
> > >   */
> > >  static const struct i2c_device_id bcm2048_id[] = {
> > > -	{ "bcm2048" , 0 },
> > > +	{ "bcm2048", 0 },
> > >  	{ },
> > >  };
> > >  MODULE_DEVICE_TABLE(i2c, bcm2048_id);
> > > _______________________________________________
> > > devel mailing list
> > > devel@linuxdriverproject.org
> > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html