Re: [RFC] adp1653: Add device tree bindings for LED controller

Pavel Machek
2014-11-20T12:12:09Z

Hi!

> I would also swap the segments of a property name to follow the convention
> as in case of "regulator-max-microamp".
>
> Updated version:
>
> ==========================================================
>
> Optional properties for child nodes:
> - max-microamp : maximum intensity in microamperes of the LED
> (torch LED for flash devices)
> - flash-max-microamp : maximum intensity in microamperes of the
> flash LED; it is mandatory if the led should
> support the flash mode
> - flash-timeout-microsec : timeout in microseconds after which the flash
> led is turned off

Works for me. Do you want to submit a patch or should I do it?

> - indicator-pattern : identifier of the blinking pattern for the
> indicator led
>

This would need a bit more documentation, no?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html