Re: [RFC] adp1653: Add device tree bindings for LED controller

Pali Rohár
2014-11-17T08:43:28Z

[-- Attachment #1: Type: Text/Plain, Size: 671 bytes --]

On Sunday 16 November 2014 08:59:28 Pavel Machek wrote:
> For device tree people: Yes, I know I'll have to create file
> in documentation, but does the binding below look acceptable?
>
> I'll clean up driver code a bit more, remove the printks.
> Anything else obviously wrong?
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Thanks,
> Pavel
>
>

Hello,

I think that this patch is probably not good and specially not
for n900. adp1653 should be registered throw omap3 isp camera
subsystem which does not have DT support yet.

See n900 legacy board camera code in file board-rx51-camera.c.

--
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]